Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format string issues #960

Closed
roehling opened this issue Nov 2, 2021 · 0 comments · Fixed by #958
Closed

Format string issues #960

roehling opened this issue Nov 2, 2021 · 0 comments · Fixed by #958
Assignees
Labels
bug Something isn't working

Comments

@roehling
Copy link
Contributor

roehling commented Nov 2, 2021

Required information

Operating system:
Debian (unstable)

Compiler version:
GCC 11.2

Observed result or behaviour:
The compiler flags inappropriate calls to wprintw()

roehling added a commit to roehling/iceoryx that referenced this issue Nov 2, 2021
The prettyPrint() function no longer uses the unsanitized input string
as format string for wprintw(), which is potentially dangerous if that
string happens to contain '%' signs.

The printMemPoolInfo() now correctly uses '%zd' instead of '%d' to
format an output value of type size_t.
roehling added a commit to roehling/iceoryx that referenced this issue Nov 2, 2021
The prettyPrint() function no longer uses the unsanitized input string
as format string for wprintw(), which is potentially dangerous if that
string happens to contain '%' signs.

The printMemPoolInfo() now correctly uses '%zd' instead of '%d' to
format an output value of type size_t.
roehling added a commit to roehling/iceoryx that referenced this issue Nov 2, 2021
The prettyPrint() function no longer uses the unsanitized input string
as format string for wprintw(), which is potentially dangerous if that
string happens to contain '%' signs.

The printMemPoolInfo() now correctly uses '%zd' instead of '%d' to
format an output value of type size_t.

Signed-off-by: Timo Röhling <timo@gaussglocke.de>
@mossmaurice mossmaurice added the bug Something isn't working label Nov 2, 2021
dkroenke added a commit that referenced this issue Nov 2, 2021
roehling added a commit to roehling/iceoryx that referenced this issue Nov 2, 2021
Signed-off-by: Timo Röhling <timo@gaussglocke.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants