Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor RouDi cleanups #91

Closed
mossmaurice opened this issue May 6, 2020 · 3 comments · Fixed by #417
Closed

Minor RouDi cleanups #91

mossmaurice opened this issue May 6, 2020 · 3 comments · Fixed by #417
Assignees
@mossmaurice
Labels
refactoring Refactor code without adding features
Milestone
High prio

Comments

@mossmaurice
Copy link
Contributor

mossmaurice commented May 6, 2020 •
edited by elBoberido
Loading

Brief feature description

Detailed information

  • Deprecate old RouDi c'tors
  • Take care of @todo in RouDi files
@mossmaurice mossmaurice added the refactoring Refactor code without adding features label May 6, 2020
@mossmaurice mossmaurice self-assigned this May 6, 2020
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Aug 24, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Rename RouDiMultiProcess
53aacd3 
Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Aug 24, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Add error handling in PortManager
95a6c05 
Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Aug 24, 2020
@mossmaurice
iox-eclipse-iceoryx#91 First step of deprecating the old RouDiApp c'tors
bf1c9c6 
Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Aug 25, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Add missing error handler call in RouDiComponents
5a3049c 
Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Aug 25, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Remove obsolete shared memory base address in …
5ddecf3 
…RouDiConfig

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
@mossmaurice mossmaurice mentioned this issue Aug 25, 2020
Merged
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Aug 25, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Replace std::string in PortManager and RouDiPr…
4f6251a 
…ocess

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Aug 25, 2020
@mossmaurice
iox-eclipse-iceoryx#25 iox-eclipse-iceoryx#91 Address review comments…
e8571c4 
… from Martin Hintz

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Aug 26, 2020
@mossmaurice
iox-eclipse-iceoryx#25 iox-eclipse-iceoryx#91 Address review findings…
f3372f7 
… from Michael Poehnl and Matthias Killat

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Aug 26, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Keep fighting CString100 in RouDi context
7a7818f 
Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
@mossmaurice mossmaurice added this to the v1.0 milestone Nov 4, 2020
@mossmaurice
Copy link
Contributor Author

Additionally main(int argc, char* argv[]) in roudi_main.cpp shall be modified to return roudi.run()

Maybe you can do that in #360 @marthtz and close this issue here?

dkroenke added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2020
@dkroenke
iox-eclipse-iceoryx#91 public link against rt and pthread
dc6eaef 
Signed-off-by: Dietrich Kroenke <dietrich.kroenke@apex.ai>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2020
@dkroenke
iox-eclipse-iceoryx#91 minor cleanups in posh and utils
7c5018d 
Signed-off-by: Dietrich Kroenke <dietrich.kroenke@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 8, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Returning the status code of run() is defacto …
e855dd3 
…standard

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 8, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Remove deprecated method in RouDiApp for next …
a377c8f 
…release

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 8, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Limit pthread names to 16 characters
93da403 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 8, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Smart c all the things
bb68c5d 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 8, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Remove outdated todo
895c00d 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 8, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Remove unecessary todo
9714232 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 8, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Print out command line parameters
2d169e3 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 8, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Remove deprecated methods in RouDiApp
5c3aad9 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 11, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Another try to fix Win and MacOS build
13ecbc9 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 11, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Rework getThreadName() API
cda2953 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 14, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Remove unused variable
443703a 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 14, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Add CompatibilityCheckLevel check test
0131a75 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 14, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Address review findings
ba00f78 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 14, 2020
@mossmaurice
iox-eclipse-iceoryx#91 More review findings \o/
edb6196 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 14, 2020
@mossmaurice
iox-eclipse-iceoryx#91 More findings
0a3e3da 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 14, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Address review findings: handle default cases …
e12c827 
…in switch, rename test cases and carve out constexpr

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 15, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Deactive pthread_setname_np() on MacOS to fix …
bed4fb4 
…build

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 15, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Remove unused parameter in MacOS pthread wrapper
f9ddbf0 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 15, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Add 'iox' prefix infront of pthread_setname_np()
a0f3c69 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 15, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Disable Thread_test on MacOS
e6152ed 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 15, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Remove unreachable branches in posix thread wr…
f085cf3 
…apper

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 15, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Replace empty test with @todo
1adbdb1 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 15, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Adapt posix thread wrapper to be more consiste…
a3b4ccd 
…nt with the rest of the code base and remove test done in cxx::string test

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice
Copy link
Contributor Author

mossmaurice commented Dec 16, 2020 •
edited by budrus
Loading

Open points:

@budrus I'll create a new issue to track this left-over. Would call in add "RouDi test coverage", ok?

mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 16, 2020
@mossmaurice
Merge remote-tracking branch 'origin/master' into iox-eclipse-iceoryx#91
17eb069 
-minor-roudi-cleanups
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 16, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Fix new review findings
4892c1a 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit that referenced this issue Dec 16, 2020
@mossmaurice
Merge pull request #417 from ApexAI/iox-#91-minor-roudi-cleanups
5a46538 
Iox #91 Clean up todo's in RouDi classes
@mossmaurice mossmaurice reopened this Dec 16, 2020
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 17, 2020
@mossmaurice
iox-eclipse-iceoryx#91 Address left-over review finding
c51faaf 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@budrus
Copy link
Contributor

budrus commented Jan 5, 2021

Open points:

* [ ]  Implement RouDiMemoryManager_Test::StreamOperatorTranslationIsCorrect

@budrus I'll create a new issue to track this left-over. Would call in add "RouDi test coverage", ok?

Will be addressed in #454

@budrus budrus closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossmaurice mossmaurice

Labels
refactoring Refactor code without adding features
Projects
None yet
Milestone
High prio
Development

Successfully merging a pull request may close this issue.

Iox #91 Clean up todo's in RouDi classes ApexAI/iceoryx
3 participants
@mossmaurice @marthtz @budrus