#315 Refactor base protocol #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the review Philip, I have made some additional changes to the protocol. Could you please re-review? |
tortmayr
force-pushed
the
di-rework
branch
2 times, most recently
from
c8ffba4 to
9b69bd0
Compare
Adapt integration code to conform to the changes of : eclipse-glsp/glsp-client#132 Also: -Fix bug and typo in glsp-theia-container-module -Cleanup implementation of glsp-client-contribution and ensure that the ready() promise resolves AFTER the server has been initialized. - Remove unncessary injected `TheiaGLSPConnector`in `GLSPTheiaDiagramServer` - Re-add WorkflowGLSPClientContribution (provides custom initialize options) - Add utility function for configuring a digram server. Requires eclipse-glsp/glsp-client#132 Part-of eclipse-glsp/glsp/issues/315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt integration code to conform to the changes of :
eclipse-glsp/glsp-client#132
Also:
-Fix bug and typo in glsp-theia-container-module
-Cleanup implementation of glsp-client-contribution and ensure that the ready() promise resolves AFTER the server has been initialized.
Requires eclipse-glsp/glsp-client#132
Part-of eclipse-glsp/glsp/issues/315