Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating widget also if GLSP widget is a child #61

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

planger
Copy link
Member

@planger planger commented Dec 21, 2020

@planger planger requested review from tortmayr and martin-fleck-at and removed request for tortmayr December 21, 2020 17:00
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I noticed one unnecessary typecheck, but that should not prevent merging
👍

@planger planger merged commit 7cda4d8 into master Jan 4, 2021
@planger planger deleted the planger/issues/168 branch January 4, 2021 11:05
@planger
Copy link
Member Author

planger commented Jan 4, 2021

@martin-fleck-at Regarding our discussion we had offline: we can already customize the actions that are sent on reload by overwriting the diagram widget (reloadModel()).

@planger
Copy link
Member Author

planger commented Jan 4, 2021

Thanks for the review @tortmayr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TheiaModelSourceChangedHandler doesn't reveal if diagram widget is a child of the actual Theia widget
2 participants