Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ModelSourceChangedAction to SourceModelChangedAction #117

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

planger
Copy link
Member

@planger planger commented Jun 1, 2022

This is to be consistent with the term source model that we now use to refer to the underlying model from which the GModel is created.

eclipse-glsp/glsp#655

@planger planger requested a review from tortmayr June 1, 2022 11:52
... to `SourceModelChangedAction`. This is to be consistent with the
term source model that we now use to refer to the underlying model from
which the GModel is created.

eclipse-glsp/glsp#655

Change-Id: Ica2359681f2edb2523aad9d2869d265ad241e381
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tortmayr tortmayr merged commit 0374c00 into master Jun 1, 2022
@tortmayr tortmayr deleted the planger/issues/655 branch June 1, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants