Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#248 Improve look and feel of UI #249

Closed

Conversation

kito99
Copy link
Contributor

@kito99 kito99 commented Apr 4, 2023

Addresses #248.

Kito D. Mann added 2 commits April 1, 2023 13:54
… font sizes and better match Jakarta EE site theme. Also removed per-component messages since there aren't really any validation errors (yet).
@eclipse-starter-bot
Copy link

Can one of the admins verify this patch?

@kito99
Copy link
Contributor Author

kito99 commented Apr 4, 2023

I'm getting this error for the ECA:

image

Not quite sure what the deal is...kito-public@virtua.tech is a valid email, but it's not the one I'm using for either my Github or Eclipse accounts.

@jeyvison
Copy link
Contributor

jeyvison commented Apr 4, 2023

Hi, @kito99 :) Can you please amend your commits with the email you used to sign the ECA, please?

@m-reza-rahman
Copy link
Contributor

Hi @ivargrimstad, could you possibly help debug? I honestly have no idea.

@scottkurz
Copy link
Contributor

Is there an easy way to shrink the size of the banner at the top? It still looks just as big to me in building and running locally.

I don't mean to criticize this PR if this was not something you were trying to accomplish here. However, that to me seemed to be the biggest "look and feel" issue, and so, if there's something easy we could do to shrink this further, maybe we could still try that? Sorry, not too familiar with the UI elements myself.

@m-reza-rahman
Copy link
Contributor

Hi @ivargrimstad, could you please comment on the above? I agree with Scott. That said, I understand we need to conform to the look and feel of the jakarta.ee site.

@kito99
Copy link
Contributor Author

kito99 commented Apr 8, 2023

@scottkurz the banner will be addressed in #246. It's out of scope for this issue (#248).

@m-reza-rahman
Copy link
Contributor

Hi @kito99, I think you will need to switch the email for the PR to the one that matches your Eclipse Foundation account.

@kito99 kito99 closed this Apr 22, 2023
@kito99
Copy link
Contributor Author

kito99 commented Apr 22, 2023

Replaced by #252.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants