Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent blowing connections number for reoccurring SSLContextFatories #5677

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

jansupol
Copy link
Contributor

No description provided.

@jansupol jansupol changed the title Prevent blowing connections number for reoccurring SSLContentFatories Prevent blowing connections number for reoccurring SSLContextFatories Jun 13, 2024
@jansupol jansupol force-pushed the keep-alive.default.connector branch from db9db38 to 40cd194 Compare June 13, 2024 21:08
@jansupol jansupol linked an issue Jun 14, 2024 that may be closed by this pull request
@jansupol
Copy link
Contributor Author

Relates to #5647

…nstances

Signed-off-by: jansupol <jan.supol@oracle.com>
@jansupol jansupol force-pushed the keep-alive.default.connector branch from 40cd194 to 645da07 Compare June 14, 2024 07:08
Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

connector.secureConnection((JerseyClient) client, (HttpURLConnection) urlConnection);
secondRequestFactory = factoryHolder.get().hashCode();

MatcherAssert.assertThat(firstRequestFactory, Matchers.equalTo(secondRequestFactory));
Copy link
Member

@jbescos jbescos Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we compare factories instead of hashCode?. It is unlikely, but two different instances could have same hashCode.

Signed-off-by: jansupol <jan.supol@oracle.com>
@senivam senivam merged commit ed233c5 into eclipse-ee4j:2.x Jun 18, 2024
7 checks passed
@senivam senivam added this to the 2.44 milestone Jun 18, 2024
senivam pushed a commit to senivam/jersey that referenced this pull request Jul 25, 2024
@sosinha31
Copy link

@senivam @jbescos Thank you for the fix. Is there a release version for this fix for the 3.1 branch?

@senivam
Copy link
Contributor

senivam commented Jul 31, 2024

@sosinha31 yes, it is merged the last week under this merge commit.

@jansupol jansupol deleted the keep-alive.default.connector branch July 31, 2024 07:07
@sosinha31
Copy link

@senivam Yes, I see the merge. Thanks. Is there a release version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeepAlive Caching stops working in 2.41
4 participants