Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JerseyEventSink#send throwing non IOExceptions #5490

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Dec 6, 2023

Relates to jakartaee/rest#1196

Maybe we should catch Throwable instead of Exception.

I don't know what was the reason to catch only IOExceptions, but in the case of Helidon a runtime exception is thrown:
java.io.UncheckedIOException: java.net.SocketException: Broken pipe

Anyway, as it returns a CompletionStage I think we should not throw exceptions in JerseyEventSink#send.

Also UncheckedIOException is caught in ChunkedOutput

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Copy link
Contributor

@jansupol jansupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to backported to 2.x, too

@senivam senivam merged commit 487cd39 into eclipse-ee4j:3.1 Dec 6, 2023
3 checks passed
@senivam senivam added this to the 3.1.5 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants