Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle equals and hashCode on MicroProfile client proxies #5324

Merged

Conversation

zUniQueX
Copy link
Contributor

@zUniQueX zUniQueX commented May 9, 2023

Proxies generated from the RestClientBuilderImpl don't properly handle equals and hashCode. Therefore clients cannot be stored in containers like Map.

This PR extends the ProxyInvocationHandler to implement equals and hashCode. Those calls are forwarded to the InvocationHandler objects of the proxies (similar to what is done in the WebResourceFactory).

@zUniQueX zUniQueX force-pushed the microprofile-client-hashcode-equals branch 2 times, most recently from fb5dcee to c528b94 Compare May 9, 2023 17:22
…ler objects

Signed-off-by: Steffen Nießing <zuniquex@protonmail.com>
@zUniQueX zUniQueX force-pushed the microprofile-client-hashcode-equals branch from c528b94 to 7aa9d1b Compare May 9, 2023 17:32
@senivam senivam merged commit 99042d6 into eclipse-ee4j:master May 10, 2023
@senivam senivam added this to the 2.40 milestone May 10, 2023
@zUniQueX zUniQueX deleted the microprofile-client-hashcode-equals branch June 3, 2023 15:40
This was referenced Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants