Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4881 - Java client connector #4940

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

zUniQueX
Copy link
Contributor

Provide a basic implementation of a client connector using java.net.http.HttpClient

Signed-off-by: Steffen Nießing zuniquex@protonmail.com

Provide a basic implementation of a client connector using java.net.http.HttpClient

Signed-off-by: Steffen Nießing <zuniquex@protonmail.com>
@senivam
Copy link
Contributor

senivam commented Dec 21, 2021

CQs for the PR:
CQ23888 - AssertJ
CQ23889 - Awaitility

@zUniQueX
Copy link
Contributor Author

@senivam Should I convert the tests to standard assertions? I think AssertJ is more intuitive, but if all other assertions are standard JUnit assertions, I could update to those.

@senivam
Copy link
Contributor

senivam commented Dec 21, 2021

@zUniQueX no-no, just leave it as is. Those dependencies will be approved and then your PR will be merged. It's OK, just wait a bit. Thank you :)

@jansupol jansupol merged commit d9f4ce2 into eclipse-ee4j:3.1 Dec 29, 2021
@jansupol
Copy link
Contributor

Merged in 2021 to prevent copyright issues

@senivam senivam added this to the 3.1.0 milestone Jan 3, 2022
@senivam
Copy link
Contributor

senivam commented Jan 5, 2022

related CQs are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants