Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jersey examples #4438

Merged
merged 17 commits into from
May 11, 2020
Merged

Fix jersey examples #4438

merged 17 commits into from
May 11, 2020

Conversation

tvallin
Copy link
Contributor

@tvallin tvallin commented Apr 8, 2020

No description provided.

Signed-off-by: tvallin <thibault.vallin@oracle.com>
("enter" does not stop the app)

Signed-off-by: tvallin <thibault.vallin@oracle.com>
dependency missing

Signed-off-by: tvallin <thibault.vallin@oracle.com>
dependency missing

Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin changed the title Fix jersey examples WIP : Fix jersey examples Apr 8, 2020
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
<dependency>
<groupId>org.jboss.weld.se</groupId>
<artifactId>weld-se-core</artifactId>
<version>3.1.1.Final</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shall be taken from dependenciesManagement, or is there some reason why it's not in dependenciesManagement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the weld version in dependenciesManagement is updated to 3.1.1.Final, the build fails in other modules.
Update the version into the example pom make it fails as well, which is why I have decided to do it this way where it does not produce any failing tests in Jersey and make helloworld-cdi2-se run with jdk11.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CQ #21928 created to allow related weld-se-core to be used in the project

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CQ is approved

@tvallin tvallin changed the title WIP : Fix jersey examples Fix jersey examples Apr 28, 2020
@tvallin tvallin requested a review from senivam May 11, 2020 07:39
@senivam senivam merged commit 94fc06d into eclipse-ee4j:master May 11, 2020
@senivam senivam modified the milestones: 2.30.1, 2.31 May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants