Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Jetty version to 9.4.24.v20191120 #4354

Closed
nddipiazza opened this issue Jan 3, 2020 · 2 comments
Closed

Bump Jetty version to 9.4.24.v20191120 #4354

nddipiazza opened this issue Jan 3, 2020 · 2 comments

Comments

@nddipiazza
Copy link

nddipiazza commented Jan 3, 2020 •
edited
Loading

We need to bump Jetty version to 9.4.24.v20191120 because a back-breaking change was introduced.

See #4302

Once we bump the version, we need to change:

https://github.com/nddipiazza/jersey/blob/12a057315292a624ceb31b58bd04eec3cb19a819/containers/jetty-http/src/main/java/org/glassfish/jersey/jetty/JettyHttpContainerFactory.java#L296

from protected to public
nddipiazza added a commit to nddipiazza/jersey that referenced this issue Jan 3, 2020
@nddipiazza
bump jetty version to 9.4.24.v20191120. see eclipse-ee4j#4354
22d4824
@nddipiazza nddipiazza mentioned this issue Jan 3, 2020
Closed
nddipiazza added a commit to nddipiazza/jersey that referenced this issue Jan 3, 2020
@nddipiazza
bump jetty version to 9.4.24.v20191120. see eclipse-ee4j#4354
93cebd2 
Signed-off-by: Nicholas DiPiazza nicholas.dipiazza@gmail.com
@nddipiazza
Copy link
Author

nddipiazza commented Jan 3, 2020 •
edited
Loading

@jansupol
I just noticed this appears already fixed on master. can you please cut a new version with this fix? it is preventing us from upgrading Jetty.

@jansupol
Copy link
Contributor

jansupol commented Apr 3, 2020

Jersey 2.30.1 contains this change. It is already out. For the next version, we upgraded to Jetty 9.4.27.v20200227 (#4425)

@jansupol jansupol closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump jetty version to 9.4.24.v20191120. see #4354 nddipiazza/jersey
2 participants
@nddipiazza @jansupol