Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI Environment - more useful log file #25180

Merged
merged 2 commits into from
Oct 9, 2024
Merged

CLI Environment - more useful log file #25180

merged 2 commits into from
Oct 9, 2024

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Oct 9, 2024 •
edited
Loading

  • load formatter just once
  • more robust log file creation
  • don't ignore exceptions, crash if logging is not possible. Basic requirement if used for some cmd line audit.
  • Uses UTF-8, not default charset
  • Uses ISO 8061 timestamp format - breaking change as original code used java.util.Date formatted as MM/dd/yyyy HH:mm:ss which is not a standard today. Despite the file is still trivial, it can be parsed automatically.

@dmatej
CLI Environment - log file
058b412 
- load formatter just once
- more robust log file creation
- don't ignore exceptions
- Use ISO 8061 timestamp format

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej dmatej added code cleaning breaking change Changes something users / app devs labels Oct 9, 2024
@dmatej dmatej added this to the 7.0.19 milestone Oct 9, 2024
@dmatej dmatej requested a review from a team October 9, 2024 12:31
@dmatej dmatej self-assigned this Oct 9, 2024
@dmatej
Refactored log file opening
181d9d5 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej dmatej requested a review from avpinchuk October 9, 2024 14:27
@dmatej dmatej merged commit fb4b712 into eclipse-ee4j:master Oct 9, 2024
2 checks passed
@dmatej dmatej deleted the cli-log-formatter branch October 9, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avpinchuk avpinchuk avpinchuk approved these changes

Assignees

@dmatej dmatej

Labels
breaking change Changes something users / app devs code cleaning
Projects
None yet
Milestone
7.0.19
Development

Successfully merging this pull request may close these issues.
2 participants
@dmatej @avpinchuk