Apply proc:none/proc:only for test compile too. #25102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prepare for the default changing in JDK 23. See https://inside.java/2024/06/18/quality-heads-up/
dmatej
requested changes
Aug 16, 2024
dmatej
reviewed
Aug 16, 2024
appserver/distributions/web/src/test/java/org/glassfish/distributions/test/EmbeddedTest.java
Outdated
Show resolved
Hide resolved
dmatej
reviewed
Aug 16, 2024
| import org.junit.jupiter.api.AfterAll; | ||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.BeforeAll; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class EmbeddedTest { |
There was a problem hiding this comment.
Yet don't forget to rename both test classes to *IT.java - then failsafe will find and execute them automatically.
There was a problem hiding this comment.
Maybe better to delete the tests. They haven't been executed for like forever, and didn't even compile before.
dmatej
approved these changes
Aug 16, 2024
avpinchuk
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prepare for the default changing in JDK 23.
See https://inside.java/2024/06/18/quality-heads-up/