Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes applications-tests on Windows #24828

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fixes applications-tests on Windows #24828

merged 1 commit into from
Feb 26, 2024

Conversation

avpinchuk
Copy link
Contributor

Summary:

  • Escape all occurrences of : and \ in the keyfile file path.
  • Uses platform line separator instead of \n when test server response.

@avpinchuk
Fixes applications tests on Windows
3a5f8a8 
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
@avpinchuk avpinchuk added this to the 7.0.13 milestone Feb 25, 2024
@avpinchuk avpinchuk self-assigned this Feb 25, 2024
arjantijms
arjantijms approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have an actual Windows instance to test, but LGTM

@avpinchuk
Copy link
Contributor Author 

[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  43:20 min
[INFO] Finished at: 2024-02-26T19:10:34+03:00
[INFO] ------------------------------------------------------------------------

D:\glassfish>

@arjantijms arjantijms merged commit fffcd67 into eclipse-ee4j:master Feb 26, 2024
2 checks passed
@avpinchuk avpinchuk deleted the fix-windows-applications-tests branch April 16, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

@dmatej dmatej Awaiting requested review from dmatej

@pzygielo pzygielo Awaiting requested review from pzygielo

@hs536 hs536 Awaiting requested review from hs536

Assignees

@avpinchuk avpinchuk

Labels
bug Something isn't working build and test improvement Windows
Projects
None yet
Milestone
7.0.13
Development

Successfully merging this pull request may close these issues.
2 participants
@avpinchuk @arjantijms