Sync of the master branch to 8.0.0 #24819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed using the JVM Options page Signed-off-by: kaido207 <kaido.hiroki@fujitsu.com>
Signed-off-by: kaido207 <kaido.hiroki@fujitsu.com>
Signed-off-by: kaido207 <kaido.hiroki@fujitsu.com>
- Using try-with
- Safer ZipEntry management, new closeable WritableArchiveEntry
- Revisited FileUtils
- deleted unused methods
- added USER_HOME file
- new ensureWritableDir method; if the directory cannot be used or created,
throws ISE
- ProprietaryReader.readFrom closes the input OR sets that to a returned object
- The behavior is not much consistent and I don't like it, but now it is
documented and better controlled.
- Implementations are final to limit risks.
- Fix: MIMEMessage is closeable!
- Fix: JsonParser doesn't close the input if it is a stream!
- AsadminSecurityUtil.GF_CLIENT_DIR constant
- by default subdir in user's home as it was before this commit
- can be reset by GF_CLIENT_DIR environment property.
- MUST be writeable, client should crash otherwise.
- ArchivistUtils deleted - duplicit to FileUtils
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- Safer impl without resource leaks (I hope, there's yet one class with really wide scope and also some finalizers, should be revisited later again). - More logs - it is hard to find what is wrong when it just does something in the background. - I wanted to write some tests around DeploymentContext, but it has too many dependencies, so it is covered just by integration tests (persistence_all ie) Signed-off-by: David Matějček <david.matejcek@omnifish.ee> # Conflicts: # appserver/tests/testcontainers/src/test/java/org/glassfish/main/test/tc/GlassFishContainer.java
Signed-off-by: David Matějček <david.matejcek@omnifish.ee> # Conflicts: # appserver/tests/testcontainers/pom.xml # appserver/tests/testcontainers/src/test/java/org/glassfish/main/test/tc/DomainRestartITest.java # appserver/tests/testcontainers/src/test/java/org/glassfish/main/test/tc/GlassFishContainer.java
Signed-off-by: David Matějček <david.matejcek@omnifish.ee> # Conflicts: # appserver/tests/testcontainers/pom.xml # appserver/tests/testcontainers/src/test/java/org/glassfish/main/test/tc/GlassFishContainer.java
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- it has to be refactored or rewritten to a more robust state Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee> # Conflicts: # appserver/jms/jms-core/src/main/java/com/sun/enterprise/connectors/jms/system/JmsProviderLifecycle.java
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Fixes eclipse-ee4j#24816 Non-ASCII characters are not saved correctly in JVM options added using the JVM Options page
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Fixes for resource leaks
# Conflicts: # appserver/deployment/jakartaee-full/src/main/java/org/glassfish/javaee/full/deployment/EarHandler.java # appserver/tests/jakartaee/pom.xml # nucleus/security/core/src/main/java/com/sun/enterprise/security/common/Util.java
arjantijms
approved these changes
Feb 22, 2024
arjantijms
added
8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.