Add OSGi Exports to HK2-Extras #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Pandrex247
changed the title
|
I am quite sure #899 did not bring this change. https://github.com/eclipse-ee4j/glassfish-hk2/pull/899/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8L261 I see it already in the beginning of 2022 and HK2 3.0.4. I have to admit that it smells bad ... does HK2 still use osgi.bundle files? Answer: yes, it does. And hk2-extras doesn't have it. Perhaps it would be good to make the bigger change ... as we did it in GlassFish already. Felix is quite good now and can do these things automatically. |
dmatej
approved these changes
May 20, 2024
avpinchuk
approved these changes
May 21, 2024
|
Oh, I forgot this is already here and I merged #1058 now, which is duplicit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds exports to the HK2-Extras module.
The subtle change to the bundle plugin config applied in #899 which fixed the global config by making it no longer ignore the instruction to not export anything means that without an override this module doesn't export anything. I'd argue it should be exporting stuff, as things can depend on it.
I've limited the exports to anything not in an "internal" package.