Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make /catalog/query handle null input #234

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Aug 1, 2024

What this PR changes/adds

Make FederatedCatalogApiController support null request body

Why it does that

we already do that for all the other "query" endpoints

Further notes

  • narrowed the test scope using mocked service

Linked Issue(s)

Closes #233

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the bug Something isn't working label Aug 1, 2024
@ndr-brt ndr-brt requested a review from wolf4ood August 1, 2024 07:43
@ndr-brt ndr-brt requested a review from bscholtes1A August 1, 2024 07:43
Copy link

github-actions bot commented Aug 1, 2024

Test Results

20 files  ±0  20 suites  ±0   48s ⏱️ -1s
66 tests +1  66 ✅ +1  0 💤 ±0  0 ❌ ±0 
75 runs  +1  75 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit b14e609. ± Comparison against base commit ba6f3fd.

♻️ This comment has been updated with latest results.

@ndr-brt ndr-brt merged commit 79dbdd4 into main Aug 1, 2024
29 checks passed
@ndr-brt ndr-brt deleted the 233-handle-null-body branch August 1, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query endpoint throws exception if body is null
2 participants