Allow registering Snowflake datasources from UI + enhancements #4585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the one in snowflake - https://docs.snowflake.com/en/developer-guide/jdbc/jdbc-parameters Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
There are scenarios where user and password are optional. For example in Snowflake where token file could be used instead. Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
delchev
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support more advanced datasource properties
Like the one in snowflake - https://docs.snowflake.com/en/developer-guide/jdbc/jdbc-parameters
Example params:
stringsQuotedForColumnDef=false,net.snowflake.jdbc.objectMapper.maxJsonStringLength=180000000,JDBC_GET_DATE_USE_NULL_TIMEZONE=true,enablePatternSearch=true,net.snowflake.jdbc.http_client_socket_timeout_in_ms=300000Update Snowflake database registration template
Make datasource user and password optional.
There are scenarios where user and password are optional. For example in Snowflake where token file could be used instead.
user/pass no longer required param for env data sources