Fix CsvimIT execution stability - improve files watching reset #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent resetting the watcher after the sync completion since this way it leads to skipped file modifications which occur during long synchronization executions. Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
iliyan-velichkov
changed the title
iliyan-velichkov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset synchronization watcher when starting synch processing instead of doing it after the sync execution is completed.
The previous approach leads to skipped file modifications synchronizations, which occur during long synchronization executions.
Example: if a long running synchronization is executing and a file change is executed in parallel, when the running synchronization complete, it will reset the synch watcher. This will lead to skipped synch execution when the next processing is triggered .
This issue was found when investigating the instability of CsvimIT test execution.