Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cached children when external file event is coming #9793

Merged
merged 3 commits into from
Jun 6, 2018
Merged

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented May 24, 2018

What does this PR do?

This changes proposal fixes the problem when folder didn't consume external file changes event when it collapsed on the UI. So before folder expand it checks if on server new items appears.

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

#9026

Release Notes

N/A

Docs PR

N/A

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs added kind/bug Outline of a bug - must adhere to the bug report template. status/in-progress This issue has been taken by an engineer and is under active development. team/ide severity/P2 Has a minor but important impact to the usage or development of the system. labels May 24, 2018
@vzhukovs vzhukovs added this to the 6.6.0 milestone May 24, 2018
@vzhukovs vzhukovs self-assigned this May 24, 2018
@vzhukovs vzhukovs requested a review from vparfonov as a code owner May 24, 2018 09:21
@vzhukovs vzhukovs removed the request for review from vparfonov May 24, 2018 09:21
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@eclipse-che eclipse-che deleted a comment from codenvy-ci May 24, 2018
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs
Copy link
Contributor Author

vzhukovs commented Jun 1, 2018

ci-test

@eclipse-che eclipse-che deleted a comment from codenvy-ci Jun 1, 2018
@eclipse-che eclipse-che deleted a comment from codenvy-ci Jun 1, 2018
@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9793
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vzhukovs vzhukovs changed the title [WIP] Update cached children when external file event is coming Update cached children when external file event is coming Jun 4, 2018
@vkuznyetsov vkuznyetsov mentioned this pull request Jun 6, 2018
33 tasks
@Ohrimenko1988
Copy link
Contributor

Usecase is scheduled to covering by selenium test
#9948

@vzhukovs vzhukovs merged commit 7f03a7f into master Jun 6, 2018
@vzhukovs vzhukovs deleted the che#9026 branch June 6, 2018 08:14
@vzhukovs vzhukovs modified the milestones: 6.6.0, 6.7.0 Jun 6, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
…e#9793)

### What does this PR do?
This changes proposal fixes the problem when folder didn't consume external file changes event when it collapsed on the UI. So before folder expand it checks if on server new items appears.

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

### What issues does this PR fix or reference?
eclipse-che#9026 

#### Release Notes
N/A

#### Docs PR
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants