Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed absolute paths to relative paths for zipped content #9400

Merged
merged 2 commits into from
May 4, 2018
Merged

Changed absolute paths to relative paths for zipped content #9400

merged 2 commits into from
May 4, 2018

Conversation

dkuleshov
Copy link

Relative issue: #9397

Changed absolute paths to relative paths for zipped content

@dkuleshov dkuleshov mentioned this pull request Apr 12, 2018
Closed
@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Apr 12, 2018
initial commit
24ec282 
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
@eclipse-che eclipse-che deleted a comment from codenvy-ci Apr 13, 2018
@dkuleshov
Copy link
Author

ci-build

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4512/

@dkuleshov
Copy link
Author

ci-test

@xcariba
Copy link

xcariba commented Apr 13, 2018

Project import does not work if zip file does not contain folders, only paths.
Example (zipinfo):
Does not work:

src/main/Example.txt

Does work:

src/
src/main/
src/main/Example.txt

ZipArchiver fails with FileNotFound exception.

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9400
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vparfonov vparfonov mentioned this pull request Apr 17, 2018
Closed
20 tasks
@xcariba
Copy link

xcariba commented Apr 17, 2018

This change adds extra folder in zip archive. (ex. in 5.21 if I download folder "src" zip archive would contain only contents of the folder. After this changes zip archive contains "src" folder and it`s contents inside.
This is probably due to fsManager API, zip method has no "skip root" parameter.

changed the way archive is created:
c675e5b 
- adding to archive only folder's content (skipping the folder itslef)  for arbitrary folder
- adding to archive all projects for workspace archive

Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
@dkuleshov
Copy link
Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9400
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@musienko-maxim
Copy link
Contributor

The selenium tests passed without new regressions.
Also was checked next features manually:

  • download folder with files by context menu with check saving relative paths
  • download projects with menu Workspace -> Download as Zip
  • download a project with menu Project -> Download as Zip
    We have not created autotests for checking this functionality. But i create issue for current sprint for developing tests:

@vparfonov vparfonov merged commit 8676ddf into master May 4, 2018
@vparfonov vparfonov deleted the che#9397 branch May 4, 2018 13:13
@benoitf benoitf added this to the 6.5.0 milestone May 4, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 4, 2018
@vparfonov vparfonov mentioned this pull request May 5, 2018
Closed
21 tasks
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
Changed absolute paths to relative paths for zipped content (eclipse-…
e219ea1 
…che#9400)

* initial commit

Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>

* changed the way archive is created:
- adding to archive only folder's content (skipping the folder itslef)  for arbitrary folder
- adding to archive all projects for workspace archive

Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vparfonov vparfonov vparfonov approved these changes

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dkuleshov @codenvy-ci @xcariba @musienko-maxim @vparfonov @benoitf