Theia stacks from Florent's theia prototype #8600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skabashnyuk
changed the title
ghost
approved these changes
Feb 5, 2018
benoitf
reviewed
Feb 5, 2018
| "id": "java-theia-docker", | ||
| "creator": "ide", | ||
| "name": "Java Theia (docker)", | ||
| "description": "Java + Theia in a sidecar container (docker)", |
There was a problem hiding this comment.
maybe we could replace "Java" by "che dev" image or "Che development"
| "commands": [] | ||
| }, | ||
| "stackIcon": { | ||
| "name": "type-java.svg", |
There was a problem hiding this comment.
should we replace the logo by something more theia ?
There was a problem hiding this comment.
I've asked but they have nothing to share.
There was a problem hiding this comment.
maybe we could do like for C++ with a generic "text" logo waiting the official logo in svg format.
Because in the che dev machine we have other tools than java.
There was a problem hiding this comment.
There was a problem hiding this comment.
ashumilova
approved these changes
Feb 5, 2018
benoitf
added
status/code-review
benoitf
approved these changes
Feb 5, 2018
benoitf
removed
the
status/code-review
This was referenced Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding two stacks. One for docker other for Openshift.
theiaide/theiaother is baseeclipse/che-dev:nightly./projectsvolumeWhat issues does this PR fix or reference?
#8267
Release Notes
n/a
Docs PR
n/a