Selenium: Add ability to catch Chrome browser`s console logs #8502

Ohrimenko1988 · 2018-01-29T14:57:32Z

What does this PR do?

Add ability to catch Chrome browser`s console logs

Output example:

2018-01-29 16:31:42,124[pool-1-thread-2]  [INFO ] [o.e.c.s.c.u.BrowserLogsUtil 61]      - SEVERE http://172.19.20.13:8080/api/keycloak/settings - Failed to load resource: the server responded with a status of 404 ()
2018-01-29 16:31:42,124[pool-1-thread-2]  [INFO ] [o.e.c.s.c.u.BrowserLogsUtil 61]      - SEVERE http://172.19.20.13:8080/che/workspace27javd 76:36 "Cannot load keycloak settings. This is normal for single-user mode."
2018-01-29 16:31:42,124[pool-1-thread-2]  [INFO ] [o.e.c.s.c.u.BrowserLogsUtil 61]      - SEVERE _app-0.js 17422 Failed to load resource: the server responded with a status of 404 ()

What issues does this PR fix or reference?

Issue: #8469

Release Notes

Docs PR

…d-browser-logs

dmytro-ndp · 2018-01-29T15:23:06Z

...ium/che-selenium-core/src/main/java/org/eclipse/che/selenium/core/utils/BrowserLogsUtil.java

+   *
+   * @return log messages from browser console
+   */
+  public String getBrowserLogsAsString() {


AsString is redundant here

dmytro-ndp · 2018-01-29T15:35:09Z

...ium/che-selenium-core/src/main/java/org/eclipse/che/selenium/core/utils/BrowserLogsUtil.java

+  /** append browser logs to the test logs */
+  public void appendBrowserLogs() {
+    getBrowserLogs()
+        .forEach(logEntry -> LOG.info(format("%s %s", logEntry.getLevel(), logEntry.getMessage())));


LOG.info("{} {}", logEntry.getLevel(), logEntry.getMessage()) is more suitable.

dmytro-ndp · 2018-01-29T15:45:45Z

...ium/che-selenium-core/src/main/java/org/eclipse/che/selenium/core/utils/BrowserLogsUtil.java

+   * @return log messages from browser console
+   */
+  public List<LogEntry> getBrowserLogs() {
+    return seleniumWebDriver.manage().logs().get(LogType.BROWSER).getAll();


It should be synchronized with loggingPreferences.enable(LogType.BROWSER, Level.SEVERE); IMHO.
For example, we can use seleniumWebDriver.manage().logs().getAvailableLogTypes() to check presence of certain type in the logs.

May be we add possible pass LogType into getBrowserLogs(). It may be very useful for investigation very specific cases? We can change signature of the method or overload exist.

SkorikSergey · 2018-01-29T15:46:31Z

selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/Ide.java

  }

  public void open(TestWorkspace testWorkspace) throws Exception {
    URL workspaceUrl = testWorkspaceUrlResolver.resolve(testWorkspace);
    seleniumWebDriver.get(workspaceUrl.toString());
    entrance.login(testWorkspace.getOwner());
+    try {
+      projectExplorer.waitProjectExplorer(60);


Use timeout constant here.

dmytro-ndp · 2018-01-29T15:48:40Z

selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/Ide.java

  }

  public void open(TestWorkspace testWorkspace) throws Exception {
    URL workspaceUrl = testWorkspaceUrlResolver.resolve(testWorkspace);
    seleniumWebDriver.get(workspaceUrl.toString());
    entrance.login(testWorkspace.getOwner());
+    try {
+      projectExplorer.waitProjectExplorer(60);


Not every open(ws) requires waitProjectExplorer() just after it. For example, CheckoutToRemoteBranchTest.

…d-browser-logs

dmytro-ndp · 2018-01-31T11:57:47Z

...ium/che-selenium-core/src/main/java/org/eclipse/che/selenium/core/utils/BrowserLogsUtil.java

+    Logs logs = seleniumWebDriver.manage().logs();
+    List<LogEntry> result = Collections.emptyList();
+
+    switch (logType) {


All switch-case statement could be replaced by one command:
return logs.get(logType).getAll();

dmytro-ndp · 2018-01-31T11:59:59Z

...ium/che-selenium-core/src/main/java/org/eclipse/che/selenium/core/utils/BrowserLogsUtil.java

+   */
+  public List<LogEntry> getLogs(String logType) {
+    Logs logs = seleniumWebDriver.manage().logs();
+    List<LogEntry> result = Collections.emptyList();


result variable is redundant if we refactor code as mentioned here.

dmytro-ndp · 2018-01-31T12:17:10Z

...ium/che-selenium-core/src/main/java/org/eclipse/che/selenium/core/utils/BrowserLogsUtil.java

+   * @see LogType
+   * @return provided type of browser logs
+   */
+  public List<LogEntry> getLogs(String logType) {


Also, it doesn't make sense to allow selection of log type which is differ from "browser" if we enabling only LogType.BROWSER logging preference by command loggingPreferences.enable(LogType.BROWSER, Level.SEVERE); in class SeleniumWebDriver.

dmytro-ndp · 2018-01-31T13:16:01Z

...ium/che-selenium-core/src/main/java/org/eclipse/che/selenium/core/utils/BrowserLogsUtil.java

+/**
+ * read and store browser logs to the test logs for change of logs level
+ *
+ * @see SeleniumWebDriver method "doCreateDriver"


Use {@link package.class#member label} notation to reference method in the docs.

dmytro-ndp · 2018-01-31T13:16:53Z

...ium/che-selenium-core/src/main/java/org/eclipse/che/selenium/core/utils/BrowserLogsUtil.java

+ * read and store browser logs to the test logs for change of logs level
+ *
+ * @see SeleniumWebDriver method "doCreateDriver"
+ * @see java.util.logging.Level


Use {@link package.class} notation to references class in the docs.

…3613 to master * commit 'd800fb816af6ed6f2d67702ac55ff5f8a8be3630': (34 commits) fixed version added new aws run script Prevents displaying installers with empty names and descriptions (eclipse-che#8536) adapt selenium tests according to changes with workspace config updating (eclipse-che#8561) Fix docs link. Dash instead underscore (eclipse-che#8548) fix aws ST-3613 custom keycloak image Dashboard: allow to update workspace config without workpace restarting (eclipse-che#8505) eclipse-che#8509 handle keybinding inside FileStructure Window (eclipse-che#8528) RELEASE: Set next development version (eclipse-che#8496) Add extra steps in the 'prepare()' to increase stability Renew URLs of CI servers to compare local selenium testing results (eclipse-che#8541) Selenium: Add ability to catch Chrome browser`s console logs (eclipse-che#8502) CHE-6923: Provide more space for committer fields in Preferences dialog. (eclipse-che#8480) Restore support of single-port Che mode (on docker infra) Factories links (eclipse-che#8530) CHE-7555 fix resolve factory flow Update policy of installers update (eclipse-che#8406) Improves debug panel, fixes UI of configure breakpoints popup (eclipse-che#8520) Update ProjectExplorerPresenter.java ...

Ohrimenko1988 added 4 commits January 26, 2018 17:38

add 'BrowserLogsUtils' class for catching browser log

d7d3861

Merge branch 'master' of https://github.com/eclipse/che into selen-ad…

12a1a21

…d-browser-logs

change catched logs level , rename methods and class, add new method

70c23cb

apply formating

8b40111

Ohrimenko1988 requested review from dmytro-ndp, musienko-maxim, artaleks9 and SkorikSergey January 29, 2018 14:57

Ohrimenko1988 requested a review from vparfonov as a code owner January 29, 2018 14:57

benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jan 29, 2018

dmytro-ndp reviewed Jan 29, 2018

View reviewed changes

artaleks9 approved these changes Jan 29, 2018

View reviewed changes

dmytro-ndp reviewed Jan 29, 2018

View reviewed changes

dmytro-ndp changed the title ~~Selenium: Add ability to catch Chrome browser`s console logs~~ [WIP] Selenium: Add ability to catch Chrome browser`s console logs Jan 29, 2018

dmytro-ndp reviewed Jan 29, 2018

View reviewed changes

SkorikSergey reviewed Jan 29, 2018

View reviewed changes

SkorikSergey approved these changes Jan 29, 2018

View reviewed changes

dmytro-ndp reviewed Jan 29, 2018

View reviewed changes

Ohrimenko1988 added 8 commits January 29, 2018 18:09

do changes according to review

c2564e1

Merge branch 'master' of https://github.com/eclipse/che into selen-ad…

3e9826b

…d-browser-logs

Merge branch 'master' of https://github.com/eclipse/che into selen-ad…

dba03af

…d-browser-logs

add ability to choose the log type

fa60e12

Merge branch 'master' of https://github.com/eclipse/che into selen-ad…

5bea13e

…d-browser-logs

add new changes for testing to the BrowserLogsUtil

103c51d

add new changes for investigating

7b51822

remove changes for testing from 'DialogAboutTest'

3a90715

dmytro-ndp reviewed Jan 31, 2018

View reviewed changes

apply changes according to review

300cd06

dmytro-ndp reviewed Jan 31, 2018

View reviewed changes

Ohrimenko1988 added 2 commits January 31, 2018 15:31

do changes according to review

994a159

remove changes from DialogAboutTest

b01767d

dmytro-ndp approved these changes Jan 31, 2018

View reviewed changes

dmytro-ndp changed the title ~~[WIP] Selenium: Add ability to catch Chrome browser`s console logs~~ Selenium: Add ability to catch Chrome browser`s console logs Jan 31, 2018

Ohrimenko1988 merged commit 4baa9ea into master Jan 31, 2018

Ohrimenko1988 deleted the selen-add-browser-logs branch January 31, 2018 13:46

Ohrimenko1988 mentioned this pull request Jan 31, 2018

Add catch Chrome browser`s console logs for investigating bug #8468 #8469

Closed

benoitf added this to the 6.0.0-M5 milestone Jan 31, 2018

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Selenium: Add ability to catch Chrome browser`s console logs #8502

Selenium: Add ability to catch Chrome browser`s console logs #8502

Ohrimenko1988 commented Jan 29, 2018 •

edited

Loading

dmytro-ndp Jan 29, 2018

dmytro-ndp Jan 29, 2018

dmytro-ndp Jan 29, 2018 •

edited

Loading

musienko-maxim Jan 30, 2018 •

edited

Loading

SkorikSergey Jan 29, 2018

dmytro-ndp Jan 29, 2018 •

edited

Loading

dmytro-ndp Jan 31, 2018

dmytro-ndp Jan 31, 2018 •

edited

Loading

dmytro-ndp Jan 31, 2018

dmytro-ndp Jan 31, 2018

dmytro-ndp Jan 31, 2018

Selenium: Add ability to catch Chrome browser`s console logs #8502

Selenium: Add ability to catch Chrome browser`s console logs #8502

Conversation

Ohrimenko1988 commented Jan 29, 2018 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

dmytro-ndp Jan 29, 2018

Choose a reason for hiding this comment

dmytro-ndp Jan 29, 2018

Choose a reason for hiding this comment

dmytro-ndp Jan 29, 2018 • edited Loading

Choose a reason for hiding this comment

musienko-maxim Jan 30, 2018 • edited Loading

Choose a reason for hiding this comment

SkorikSergey Jan 29, 2018

Choose a reason for hiding this comment

dmytro-ndp Jan 29, 2018 • edited Loading

Choose a reason for hiding this comment

dmytro-ndp Jan 31, 2018

Choose a reason for hiding this comment

dmytro-ndp Jan 31, 2018 • edited Loading

Choose a reason for hiding this comment

dmytro-ndp Jan 31, 2018

Choose a reason for hiding this comment

dmytro-ndp Jan 31, 2018

Choose a reason for hiding this comment

dmytro-ndp Jan 31, 2018

Choose a reason for hiding this comment

Ohrimenko1988 commented Jan 29, 2018 •

edited

Loading

dmytro-ndp Jan 29, 2018 •

edited

Loading

musienko-maxim Jan 30, 2018 •

edited

Loading

dmytro-ndp Jan 29, 2018 •

edited

Loading

dmytro-ndp Jan 31, 2018 •

edited

Loading