Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing lib to be able to configure LogstashEncoder on wsagent #7444

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

skabashnyuk
Copy link
Contributor

What does this PR do?

Added missing lib to be able to configure LogstashEncoder on wsagent. Removed unused libs from ws-master war

What issues does this PR fix or reference?

LogstashEncoder is possible to configure on ws-master and ws-agent tomcat.

Release Notes

n/a

Docs PR

…r.LogstashEncoder on wsagent. Removed unused libs from ws-master war
@skabashnyuk
Copy link
Contributor Author

war file for quick testing https://github.com/skabashnyuk/war-slf4j

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. target/che6 status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Nov 19, 2017
Copy link
Contributor

@sunix sunix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skabashnyuk skabashnyuk merged commit ed0ce61 into che6 Nov 21, 2017
@skabashnyuk skabashnyuk deleted the logstash-logback-encode branch November 21, 2017 09:40
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 21, 2017
@benoitf benoitf added this to the 6.0.0-M2 milestone Nov 21, 2017
skabashnyuk added a commit that referenced this pull request Nov 27, 2017
…r.LogstashEncoder on wsagent. Removed unused libs from ws-master war (#7444)
skabashnyuk added a commit that referenced this pull request Nov 27, 2017
…r.LogstashEncoder on wsagent. Removed unused libs from ws-master war (#7444) (#7566)
JPinkney pushed a commit to JPinkney/che that referenced this pull request Nov 29, 2017
…r.LogstashEncoder on wsagent. Removed unused libs from ws-master war (eclipse-che#7444) (eclipse-che#7566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants