Fix url encoding in DefaultHttpJsonRequest #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akorneta
force-pushed
the
fix_url_encode
branch
from
5b8665d to
0d1787d
Compare
| @@ -34,7 +34,6 @@ | |||
| import javax.ws.rs.core.MediaType; | |||
| import javax.ws.rs.core.Response; | |||
| import javax.ws.rs.core.UriBuilder; | |||
|
|
|||
There was a problem hiding this comment.
Why did you remove this line ? spec
|
ок |
|
@akorneta Please run selenium test to ensure everything will work as expected. |
|
ok |
akorneta
force-pushed
the
fix_url_encode
branch
from
0d1787d to
19ff670
Compare
akorneta
force-pushed
the
fix_url_encode
branch
from
19ff670 to
cfba018
Compare
akorneta
added a commit
that referenced
this pull request
Mar 17, 2016
Fix url encoding in DefaultHttpJsonRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@skabashnyuk @evoevodin
UriBuilder.build() performs encode it was necessary to get rid of second encoding of query params