Language Server Protocol Rename implementation #6615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 3, 2017 10:29
Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>
Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>
Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>
benoitf
added
status/code-review
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4035/ |
tsmaeder
reviewed
Oct 9, 2017
| if (!isStartWithProject(filePath)) { | ||
| filePath = prefixProject(filePath); | ||
| } | ||
| String fileContent = |
There was a problem hiding this comment.
Sorry to chime in late, but since we'll face a similar problem with the "references" for the jdt.ls, etc. I think this approach will not scale for large sets of changes. We should be thinking towards a UI where we fetch the concrete line changes ("snippets") when we need them.
vparfonov
reviewed
Oct 9, 2017
| String matchedLine = change.getTextEdit().getLineText(); | ||
| int startOffset = change.getTextEdit().getInLineStart(); | ||
| int endOffset = change.getTextEdit().getInLineEnd(); | ||
| if (matchedLine != null /*&& matchInLine != null*/) { |
| } | ||
| spanElement.appendChild(textElement); | ||
|
|
||
| // presentation.setPresentableIcon(resources.searchMatch()); |
| @@ -134,12 +150,15 @@ public void onFileOperation(final FileEvent event) { | |||
| break; | |||
| } | |||
| } | |||
| // onOpen(event.getEditor(), event.getFile(), dtoFactory, serviceClient, fileTypeRegister); | |||
| // onOpen(event.getEditor(), event.getFile(), dtoFactory, serviceClient, | |||
vparfonov
approved these changes
Oct 9, 2017
Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add implementation of LSP Rename
What issues does this PR fix or reference?
#1806
Release Notes
Language Server Protocol Rename implementation