Fetch module config directly from item reference #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get children operation (on the server side, project service) is returning item reference with project configuration for the module if such exists. Client based on this information may faster construct module node instead of making additional request for the configuration. Note: temporary solution will be alive before new changes will be merged (related to new project type with server side vfs refactorings) Related issue: CHE-660 Squashed commit of the following: commit e86d058 Merge: 32caa18 7b6bb02 Author: Vladyslav Zhukovskii <vzhukovskii@codenvy.com> Date: Tue Mar 1 17:42:55 2016 +0200 Merge branch 'master' into CHE-660 commit 32caa18 Author: Vladyslav Zhukovskii <vzhukovskii@codenvy.com> Date: Tue Mar 1 17:37:36 2016 +0200 Fetch module config directly from item reference commit 04513ae Author: Dmitry Shnurenko <dshnurenko@codenvy.com> Date: Tue Mar 1 17:06:12 2016 +0200 CHE-660: Add java doc commit 20e99f8 Author: Dmitry Shnurenko <dshnurenko@codenvy.com> Date: Tue Mar 1 16:57:56 2016 +0200 CHE-660: Improve server side code to less time of getting project Signed-off-by: Vladyslav Zhukovskii <vzhukovskii@codenvy.com>
|
Getting projects operation for che has reduced from ~26sec to ~279ms. |
|
ok, good job |
|
ok |
vzhukovs
pushed a commit
that referenced
this pull request
Mar 1, 2016
Fetch module config directly from item reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get children operation (on the server side, project service) is returning item reference with project configuration for the module if such exists. Client based on this information may faster construct module node instead of making additional request for the configuration.
Note: temporary solution will be alive before new changes will be merged (related to new project type with server side vfs refactorings)
Related issue: CHE-660
@vparfonov @dimasnurenko review this PR.
Squashed commit of the following:
commit e86d058
Merge: 32caa18 7b6bb02
Author: Vladyslav Zhukovskii vzhukovskii@codenvy.com
Date: Tue Mar 1 17:42:55 2016 +0200
commit 32caa18
Author: Vladyslav Zhukovskii vzhukovskii@codenvy.com
Date: Tue Mar 1 17:37:36 2016 +0200
commit 04513ae
Author: Dmitry Shnurenko dshnurenko@codenvy.com
Date: Tue Mar 1 17:06:12 2016 +0200
commit 20e99f8
Author: Dmitry Shnurenko dshnurenko@codenvy.com
Date: Tue Mar 1 16:57:56 2016 +0200
Signed-off-by: Vladyslav Zhukovskii vzhukovskii@codenvy.com