CHE-661 unzip in quiet mode #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if we need that in codenvy hosted we need to change it here aswell: |
|
I can issue PR on erb files |
|
Why you want to make it quiet? |
|
@garagatyi on a meeting we've decided to get rid of that useless output when ws is starting. |
|
@garagatyi because it looks ugly to see that when we start agent and if unzip fails we will have error BTW |
|
than ok |
|
LGTM |
Change-Id: If3a51cc6e01e243c47033d4d891858e3997ab725 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Katka92
pushed a commit
to Katka92/che
that referenced
this pull request
Jun 27, 2018
Use subject of a user that started workspace instead of current subject if user ID of current subject differ from user ID of the user that started the workspace. Rework logging of a warning to be thrown in case when current user ID differs from a workspace starter user ID and there is no subject of the user that started workdpace in subjects cache. Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: If3a51cc6e01e243c47033d4d891858e3997ab725
Signed-off-by: Florent BENOIT fbenoit@codenvy.com