CODENVY-170 add promise-based authorization method to OAUth authenticators; prevent project synchronizing when factory used #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ators; prevent project synchronizing when factory used Signed-off-by: Max Shaposhnik <mshaposhnik@codenvy.com>
|
good job! |
| @@ -21,5 +22,7 @@ | |||
|
|
|||
| void authorize(String authenticatorUrl, AsyncCallback<OAuthStatus> callback); | |||
|
|
|||
| Promise<OAuthStatus> authorize(String authenticationUrl); | |||
There was a problem hiding this comment.
authorize but authenticationUrl
Mb authorizationUrl? or authenticate?
|
ок |
| @@ -19,7 +20,9 @@ | |||
| */ | |||
| public interface OAuth2Authenticator { | |||
|
|
|||
| void authorize(String authenticatorUrl, AsyncCallback<OAuthStatus> callback); | |||
| void authenticate(String authenticatorUrl, AsyncCallback<OAuthStatus> callback); | |||
There was a problem hiding this comment.
first method with authenticatorUrl and second method with authenticationUrl. If there isn't any difference between them let's make them the same
|
other OK |
Signed-off-by: Max Shaposhnik <mshaposhnik@codenvy.com>
mshaposhnik
added a commit
that referenced
this pull request
Mar 1, 2016
CODENVY-170 add promise-based authorization method to OAUth authenticators; prevent project synchronizing when factory used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ators; prevent project synchronizing when factory used
Signed-off-by: Max Shaposhnik mshaposhnik@codenvy.com