CHE-3048: add new workspace creation flow #5447

akurinnoy · 2017-06-23T07:30:58Z

What does this PR do?

This PR provides new workspace creation flow with the following improvements:

removed the ability to create a workspace from a custom stack
removed ability to use a recipe from a URL
created stack selector widget
added button "Add Stack" which will redirect to Stack creation page
restyle label container
restyle input fields
created number spinner widget
created widget for displaying advanced filter

What issues does this PR fix or reference?

#2971
#3212
#3213
#3214
#3392
#5166

Changelog

[UD] added new simplified workspace creation flow

Release Notes

This version introduces a major usability improvement on the dashboard. We have created a new flow to create a workspace. This flow is simpler to understand and simpler to use. We also have unified the experience, so that you can always add a project while creating a workspace. The flow is consistent from the different places on the dashboard where you can create a workspace.

There are 3 main steps when creating a workspace:
1- Assigning a name
2- Selecting a stack for the workspace runtime
3- Configuring the workspace's resources

The logical next step is to add or import projects in the workspace. That step is becoming more flexible, so you decide if you want to add one or multiple projects while creating the workspace - or if you prefer to import the projects later.

Let us know what you think!

Docs PR

https://github.com/eclipse/che-docs/pull/252/files

codenvy-ci · 2017-06-23T08:55:13Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2899/

slemeur · 2017-06-23T10:37:33Z

slemeur · 2017-06-23T10:43:43Z

It seems we have a bug when:

start with a predefined stack
add a project samples provided for the stack
before creating the workspace, rename the project

Actual result: A blank project is added into the workspace
Expected result: The selected project samples would be clone and the project renamed in the workspace

slemeur · 2017-06-23T10:47:16Z

Other feedbacks from sprint demo:

GitHub is misspelled in the stack selector.
Need to revisit three text descriptions as they were too long, redundant or typos:

SELECT STACK
Choose your workspace runtime environment used to build and run your projects.

Change "RAM SETTING" to "RAM"
"Allocate the workspace machine(s) memory.

Change the filter text:
"Type a technology to narrow your selection."

Decimal place consistency on the RAM setting

codenvy-ci · 2017-06-26T18:50:52Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2921/

codenvy-ci · 2017-06-27T07:18:05Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2923/

codenvy-ci · 2017-06-27T10:15:19Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2925/

codenvy-ci · 2017-06-27T14:35:08Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2931/

codenvy-ci · 2017-07-03T08:55:28Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2974/

ashumilova · 2017-07-06T08:36:19Z

Known issue, found during testing #5545

olexii4 · 2017-07-06T09:09:51Z

dashboard/src/app/colors/che-colors.styl

+// create-workspace flow
+$grey-input-label-color = #91979F
+$very-light-grey-background-color = #F7F7F7
+


Why aren't they in file 'colors.json' like other 20 color constants? I guess it should be one place for constant.

we defined color.json as application colors palette, now seems new are added, but need to deal - it's really new ones or replacement for existing

olexii4 · 2017-07-06T09:53:39Z

...kspaces/create-workspace/stack-selector/stack-selector-item/stack-selector-item.directive.ts

+ *
+ * @author Oleksii Kurinnyi
+ */
+export class StackSelectorItem {


I saw an implementation of ng.IDirective in other directives for this PR. Could we make it as a rule?

+1, also prefer to point it directly. let's make as a rule

olexii4 · 2017-07-06T10:08:41Z

dashboard/src/app/workspaces/workspace-config.service.ts

+   *
+   * @param {any} error error object or string
+   */
+  private logError(error: any): void {


I saw using this private logError once for the service. I guess we should have something looks like in separate error service because we have a lot of places with error.data.message checking.

codenvy-ci · 2017-07-06T10:25:44Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3005/

ashumilova · 2017-07-07T07:22:48Z

QA PR - #5256
Test Report - https://ci.codenvycorp.com/view/qa/job/a2-selenium-tests/25/Selenium_tests_report/

slemeur · 2017-07-07T09:36:49Z

added release note.

codenvy-ci · 2017-07-07T12:12:57Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3019/

Signed-off-by: Anna Shumilova <ashumilo@redhat.com> CHE-2971: add toggle widgets added directives: - che-toggle-joined - che-toggle-joined-button - che-toggle-single-button Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> CHE-2971: add change-memory-unit filter and rename filter cheNumberRoundFilter => numberRound Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> CHE-2971: add chips-list widget Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> CHE-2971: add 'stacks' icon into che-font. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> CHE-2971: add stack-selector and stack-selector-item components Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> add stack-selector to demo-components page Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> CHE-2971: add number-spinner widget Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> clean-up che-button-* directives Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> update demo-components component Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> code clean-up Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> CHE-3048: add template-selector and template-selector-item components. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> CHE-3048: add create-workspace component. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

Signed-off-by: Oleksii Orel <oorel@redhat.com>

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> code clean-up Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

Signed-off-by: Oleksii Orel <oorel@redhat.com>

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> make page loading smooth Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> align container's lable and input in 'Name' section Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> Add attributes needed for tests Signed-off-by: Anna Shumilova <ashumilo@redhat.com> reload iframe with IDE after all of the projects are added and imported Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> fix styles for select stack widgets Signed-off-by: Oleksii Orel <oorel@redhat.com> fixup! fix styles for select stack widgets Fix GitHub loading repos and some feedbacks Signed-off-by: Anna Shumilova <ashumilo@redhat.com> fixup! fix styles for select stack widgets fixup! Fix GitHub loading repos and some feedbacks

Signed-off-by: Anna Shumilova <ashumilo@redhat.com>

codenvy-ci · 2017-07-10T12:09:59Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3023/

akurinnoy force-pushed the CHE-3048 branch from 22d8cf3 to 12f6d77 Compare June 23, 2017 07:41

ashumilova requested a review from olexii4 June 23, 2017 10:38

ashumilova self-assigned this Jun 23, 2017

ashumilova added kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development. labels Jun 23, 2017

olexii4 mentioned this pull request Jun 27, 2017

change angular-bootstrap version to 1.1.2 codenvy/codenvy#2288

Merged

ashumilova force-pushed the CHE-3048 branch from 527ca9f to afdd1bc Compare June 27, 2017 13:17

ashumilova removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 2, 2017

ashumilova changed the title ~~[WIP] CHE-3048: add new workspace creation flow~~ CHE-3048: add new workspace creation flow Jul 2, 2017

ashumilova force-pushed the CHE-3048 branch from afdd1bc to 9a2591a Compare July 3, 2017 07:20

ashumilova force-pushed the CHE-3048 branch from 9a2591a to dfaa8b2 Compare July 6, 2017 07:29

ashumilova requested review from benoitf and slemeur July 6, 2017 08:37

ashumilova force-pushed the CHE-3048 branch from dfaa8b2 to 2015ac3 Compare July 6, 2017 08:38

olexii4 approved these changes Jul 6, 2017

View reviewed changes

slemeur approved these changes Jul 7, 2017

View reviewed changes

ashumilova force-pushed the CHE-3048 branch from 2015ac3 to a1b99cf Compare July 7, 2017 11:14

benoitf removed their request for review July 7, 2017 11:30

ashumilova approved these changes Jul 7, 2017

View reviewed changes

ashumilova added this to the 5.15.0 milestone Jul 7, 2017

Oleksii Kurinnyi and others added 14 commits July 10, 2017 13:48

CHE-3048: add ram-settings and ram-settings-machine-item components

3ed27df

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> update demo-components component Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> code clean-up Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

CHE-3392: add widget for displaying advanced filter

cfcc075

Signed-off-by: Oleksii Orel <oorel@redhat.com>

CHE-5198: improve stacks list styles

66d68a9

Signed-off-by: Oleksii Orel <oorel@redhat.com>

CHE-5166: add import-blank-project component

2d78442

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

CHE-5166: add import-git-project component

f13703c

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

CHE-5166: add import-zip-project component

b71ea39

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

CHE-5166: add import-github-project component

873fd12

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

CHE-3048: add project-metadata component

8abf2c0

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

CHE-5166: add project-source-selector component

b6fbaac

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> code clean-up Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

improve project source selector widget

877da06

Signed-off-by: Oleksii Orel <oorel@redhat.com>

Fix unique workspace name validation

7b832d6

Signed-off-by: Anna Shumilova <ashumilo@redhat.com>

ashumilova force-pushed the CHE-3048 branch from a1b99cf to 7b832d6 Compare July 10, 2017 11:10

ashumilova merged commit 5c4db40 into master Jul 10, 2017

ashumilova deleted the CHE-3048 branch July 10, 2017 11:17

slemeur mentioned this pull request Sep 18, 2017

Redesigned experience for managing workspaces #4359

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CHE-3048: add new workspace creation flow #5447

CHE-3048: add new workspace creation flow #5447

akurinnoy commented Jun 23, 2017 •

edited by slemeur

Loading

codenvy-ci commented Jun 23, 2017

slemeur commented Jun 23, 2017 •

edited by ashumilova

Loading

slemeur commented Jun 23, 2017

slemeur commented Jun 23, 2017 •

edited by ashumilova

Loading

codenvy-ci commented Jun 26, 2017

codenvy-ci commented Jun 27, 2017

codenvy-ci commented Jun 27, 2017

codenvy-ci commented Jun 27, 2017

codenvy-ci commented Jul 3, 2017

ashumilova commented Jul 6, 2017

olexii4 Jul 6, 2017

ashumilova Jul 6, 2017

ashumilova Jul 7, 2017

olexii4 Jul 6, 2017

ashumilova Jul 6, 2017

ashumilova Jul 7, 2017

olexii4 Jul 6, 2017

ashumilova Jul 6, 2017

codenvy-ci commented Jul 6, 2017

ashumilova commented Jul 7, 2017

slemeur commented Jul 7, 2017

codenvy-ci commented Jul 7, 2017

codenvy-ci commented Jul 10, 2017

CHE-3048: add new workspace creation flow #5447

CHE-3048: add new workspace creation flow #5447

Conversation

akurinnoy commented Jun 23, 2017 • edited by slemeur Loading

What does this PR do?

What issues does this PR fix or reference?

Changelog

Release Notes

Docs PR

codenvy-ci commented Jun 23, 2017

slemeur commented Jun 23, 2017 • edited by ashumilova Loading

slemeur commented Jun 23, 2017

slemeur commented Jun 23, 2017 • edited by ashumilova Loading

codenvy-ci commented Jun 26, 2017

codenvy-ci commented Jun 27, 2017

codenvy-ci commented Jun 27, 2017

codenvy-ci commented Jun 27, 2017

codenvy-ci commented Jul 3, 2017

ashumilova commented Jul 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codenvy-ci commented Jul 6, 2017

ashumilova commented Jul 7, 2017

slemeur commented Jul 7, 2017

codenvy-ci commented Jul 7, 2017

codenvy-ci commented Jul 10, 2017

akurinnoy commented Jun 23, 2017 •

edited by slemeur

Loading

slemeur commented Jun 23, 2017 •

edited by ashumilova

Loading

slemeur commented Jun 23, 2017 •

edited by ashumilova

Loading