Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display configured project in project explorer after importing project #352

Merged
merged 1 commit into from
Feb 17, 2016

Conversation

RomanNikitenko
Copy link
Member

Signed-off-by: Roman Nikitenko rnikitenko@codenvy.com

We should fire CreateProjectEvent to display configured project in project explorer after importing project

@sleshchenko
Copy link
Member

Commit message says about displaying smth but in the fact its changes sends event CreateProjectEvent after importing of project. Maybe it would better to fix commit message in accordance to changes

@RomanNikitenko
Copy link
Member Author

What do you mean?
Change commit message to "sends event CreateProjectEvent after importing of project."?
But this commit will fix displaying configured project in project explorer and it does not matter which way.
Way how we reach it we can see in the changes...

@sleshchenko
Copy link
Member

I mean that commit message should describe commit's changes. For now it is hard to understand that 'Display...' means adding missed firing of event that invoke some method with displaying new project in project tree. So you can change commit message to "Add sending of CreateProjectEvent after importing of project". And if you want to describe why you did these changes you can add number of issue in titile of commit message or use body of commit message.

@RomanNikitenko
Copy link
Member Author

I think we can see in changes "Add sending of CreateProjectEvent after importing of project"
But why we do it?
I think my message is more informative for next developer...

@vparfonov
Copy link
Contributor

ok

…importing project

Signed-off-by: Roman Nikitenko <rnikitenko@codenvy.com>
@RomanNikitenko RomanNikitenko force-pushed the displayConfiguredProject branch from 86b9d0b to 88fda3a Compare February 17, 2016 10:13
RomanNikitenko added a commit that referenced this pull request Feb 17, 2016
CHE-507. Fix displaying configured project in project explorer after importing project
@RomanNikitenko RomanNikitenko merged commit 9c6047f into master Feb 17, 2016
@RomanNikitenko RomanNikitenko deleted the displayConfiguredProject branch February 17, 2016 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants