-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHE-1758 Display loading steps when booting ws from IDE #2352
Conversation
Please provide elements so that we can review the results: animated gif would be nice. |
Build # 318 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/318/ to view the results. |
Build # 336 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/336/ to view the results. |
Build # 354 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/354/ to view the results. |
Build # 357 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/357/ to view the results. |
f03a0a3
to
78d7b5c
Compare
@vitaliy-guliy - nice work!. Can we make much more narrow the width in this graphic? It needs to be wide enough to support machine names of about 15 characters, but not as wide as it is now. |
@@ -0,0 +1,98 @@ | |||
package org.eclipse.che.ide.ui.loaders; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add license
Build # 366 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/366/ to view the results. |
@@ -0,0 +1,26 @@ | |||
package org.eclipse.che.ide.ui.loaders; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add license
make sure |
|
||
public enum Phase { | ||
|
||
STARTING_WORKSPACE_RUNTIME("Starting workspace runtime", "Retrieving the stack's image and launching it"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be moved to localization
Build # 373 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/373/ to view the results. |
@TylerJewell Yes, sure. Trying to reduce the width. |
Signed-off-by: Vitaliy Guliy <vguliy@codenvy.com>
2e9bfa1
to
b0fb135
Compare
Everything is fixed. |
+1 |
ok |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/392/ |
CHE-1758 Display loading steps when booting ws from IDE
Displays a new loader on top of the IDE
#1758
Signed-off-by: Vitaliy Guliy vguliy@codenvy.com