Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-1758 Display loading steps when booting ws from IDE #2352

Merged
merged 2 commits into from
Sep 13, 2016
Merged

Conversation

vitaliy-guliy
Copy link
Contributor

Displays a new loader on top of the IDE

#1758

Signed-off-by: Vitaliy Guliy vguliy@codenvy.com

@slemeur
Copy link
Contributor

slemeur commented Sep 6, 2016

Please provide elements so that we can review the results: animated gif would be nice.

@codenvy-ci
Copy link

Build # 318 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/318/ to view the results.

@codenvy-ci
Copy link

Build # 336 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/336/ to view the results.

@codenvy-ci
Copy link

Build # 354 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/354/ to view the results.

@codenvy-ci
Copy link

Build # 357 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/357/ to view the results.

@vitaliy-guliy
Copy link
Contributor Author

@TylerJewell
Copy link

@vitaliy-guliy - nice work!. Can we make much more narrow the width in this graphic? It needs to be wide enough to support machine names of about 15 characters, but not as wide as it is now.
capture

@@ -0,0 +1,98 @@
package org.eclipse.che.ide.ui.loaders;
Copy link
Contributor

@olexii4 olexii4 Sep 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add license

@codenvy-ci
Copy link

Build # 366 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/366/ to view the results.

@@ -0,0 +1,26 @@
package org.eclipse.che.ide.ui.loaders;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add license

@ashumilova
Copy link
Contributor

make sure mvn license:check passes


public enum Phase {

STARTING_WORKSPACE_RUNTIME("Starting workspace runtime", "Retrieving the stack's image and launching it"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be moved to localization

@codenvy-ci
Copy link

Build # 373 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/373/ to view the results.

@vitaliy-guliy
Copy link
Contributor Author

@TylerJewell Yes, sure. Trying to reduce the width.

Signed-off-by: Vitaliy Guliy <vguliy@codenvy.com>
@vitaliy-guliy
Copy link
Contributor Author

dark theme
light theme

@vitaliy-guliy
Copy link
Contributor Author

Everything is fixed.

@ashumilova
Copy link
Contributor

+1

@vparfonov
Copy link
Contributor

ok

@vitaliy-guliy vitaliy-guliy merged commit e3bbe91 into master Sep 13, 2016
@vitaliy-guliy vitaliy-guliy deleted the CHE-1758 branch September 13, 2016 11:37
@codenvy-ci
Copy link

@bmicklea bmicklea added this to the 5.0.0 milestone Jan 11, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
CHE-1758 Display loading steps when booting ws from IDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants