Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added getLoaderAlert() method and getAllCreatedWorkspacesNames() into page objects. #22020

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Added getLoaderAlert() method and getAllCreatedWorkspacesNames() into page objects. #22020

merged 1 commit into from
Feb 28, 2023

Conversation

nallikaea
Copy link
Contributor

@nallikaea nallikaea commented Feb 23, 2023 •
edited
Loading

What does this PR do?

New methods getLoaderAlert() and getAllCreatedWorkspacesNames() is used in RefusedOAuthFactory.spec.ts e2e-codready test suite.

  • getLoaderAlert() - get alert message if any error on workspace loader page;
  • getAllCreatedWorkspacesNames() returns names of created workspaces as string array;

What issues does this PR fix or reference?

as part of:

How to test this PR?

Test run:

image

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added target/branch Indicates that a PR will be merged into a branch other than master. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/planning A checklist of issues for planning a particular sprint. labels Feb 23, 2023
ScrewTSW
ScrewTSW approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@ScrewTSW ScrewTSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small remark

Added getLoaderAlert() method and getAllCreatedWorkspacesNames() into…
8fd0486 
… page objects.

Signed-off-by: mdolhalo <mdolhalo@redhat.com>
ScrewTSW
ScrewTSW approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@ScrewTSW ScrewTSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dmytro-ndp
dmytro-ndp approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmytro-ndp dmytro-ndp merged commit ac03d90 into eclipse-che:main Feb 28, 2023
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 28, 2023
@che-bot che-bot added this to the 7.62 milestone Feb 28, 2023
@nallikaea nallikaea mentioned this pull request Mar 1, 2023
Merged
9 tasks
@nallikaea nallikaea deleted the crw-3816 branch April 13, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@ScrewTSW ScrewTSW ScrewTSW approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim musienko-maxim is a code owner

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees
No one assigned
Labels
kind/planning A checklist of issues for planning a particular sprint. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
7.62
Development

Successfully merging this pull request may close these issues.
4 participants
@nallikaea @dmytro-ndp @ScrewTSW @che-bot