-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factories for private Gitlab repository with pre-created personal access token #19351
Merged
mshaposhnik
merged 8 commits into
eclipse-che:master
from
mshaposhnik:gitlab_with_tokens
Mar 30, 2021
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fa757ef
Support for private gitlab factories
mshaposhnik d3d8962
Fixups
mshaposhnik 87b9b47
Fmt fix
mshaposhnik 418f56c
Fixups
mshaposhnik 5e990a3
Fixups
mshaposhnik 6d24c52
Fixups
mshaposhnik 69ca3eb
Fixups
mshaposhnik 88142e0
Tests fixups
mshaposhnik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
.../java/org/eclipse/che/api/factory/server/gitlab/GitlabAuthorizingFileContentProvider.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Copyright (c) 2012-2018 Red Hat, Inc. | ||
* This program and the accompanying materials are made | ||
* available under the terms of the Eclipse Public License 2.0 | ||
* which is available at https://www.eclipse.org/legal/epl-2.0/ | ||
* | ||
* SPDX-License-Identifier: EPL-2.0 | ||
* | ||
* Contributors: | ||
* Red Hat, Inc. - initial API and implementation | ||
*/ | ||
package org.eclipse.che.api.factory.server.gitlab; | ||
|
||
import org.eclipse.che.api.factory.server.scm.AuthorizingFileContentProvider; | ||
import org.eclipse.che.api.factory.server.scm.GitCredentialManager; | ||
import org.eclipse.che.api.factory.server.scm.PersonalAccessTokenManager; | ||
import org.eclipse.che.api.workspace.server.devfile.URLFetcher; | ||
|
||
/** Gitlab specific authorizing file content provider. */ | ||
class GitlabAuthorizingFileContentProvider extends AuthorizingFileContentProvider<GitlabUrl> { | ||
|
||
GitlabAuthorizingFileContentProvider( | ||
GitlabUrl githubUrl, | ||
URLFetcher urlFetcher, | ||
GitCredentialManager gitCredentialManager, | ||
PersonalAccessTokenManager personalAccessTokenManager) { | ||
super(githubUrl, urlFetcher, personalAccessTokenManager, gitCredentialManager); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 0 additions & 46 deletions
46
...ab/src/main/java/org/eclipse/che/api/factory/server/gitlab/GitlabFileContentProvider.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this needs to be encoded as
%2f
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's requirement of API: