-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dependency #1844
fix dependency #1844
Conversation
+1 |
@skabashnyuk WDYT can we add |
+1 |
@ashumilova you mean 2.1.3 ? should we downgrade to 2.1.3 in that PR? |
yes, 2.1.3 |
OK, LGTM but please @akurinnoy make sure it works on Codenvy also. |
Is there a link to the PB CQ for jquery 2.1.3 ? |
@riuvshin Codenvy works fine on my side |
@benoitf you mean this one https://dev.eclipse.org/ipzilla/show_bug.cgi?id=9503 ? |
@riuvshin this one is a a PB CQ but not for che |
@benoitf yes it is for other project, but do we really need CQ for CHE with exactly same dependency? |
yes we need a PB like https://dev.eclipse.org/ipzilla/show_bug.cgi?id=9980 |
0a75b5c
to
2559654
Compare
I see, so please some one create CQ for that. and let me know when it will be merged. |
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
2559654
to
c3a8f37
Compare
1.8.1 is approved with PB CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=10801 |
Build # 1243 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1243/ to view the results. |
Fix dependencies:
related issue: #1834
Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com