Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependency #1844

Merged
merged 1 commit into from
Jul 19, 2016
Merged

fix dependency #1844

merged 1 commit into from
Jul 19, 2016

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Jul 18, 2016

Fix dependencies:

  • remove angular-card
  • add jQuery

related issue: #1834

Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com

@olexii4
Copy link
Contributor

olexii4 commented Jul 18, 2016

+1

@riuvshin
Copy link
Contributor

riuvshin commented Jul 18, 2016

@skabashnyuk WDYT can we add jquery": "2.1.4" without CQ?

@ashumilova
Copy link
Contributor

+1

@ashumilova
Copy link
Contributor

ashumilova commented Jul 18, 2016

@riuvshin
Copy link
Contributor

@ashumilova you mean 2.1.3 ? should we downgrade to 2.1.3 in that PR?

@ashumilova
Copy link
Contributor

ashumilova commented Jul 18, 2016

yes, 2.1.3

@riuvshin
Copy link
Contributor

OK, LGTM but please @akurinnoy make sure it works on Codenvy also.

@benoitf
Copy link
Contributor

benoitf commented Jul 18, 2016

Is there a link to the PB CQ for jquery 2.1.3 ?

@akurinnoy
Copy link
Contributor Author

@riuvshin Codenvy works fine on my side

@riuvshin
Copy link
Contributor

@benoitf
Copy link
Contributor

benoitf commented Jul 18, 2016

@riuvshin this one is a a PB CQ but not for che

@riuvshin
Copy link
Contributor

@benoitf yes it is for other project, but do we really need CQ for CHE with exactly same dependency?
and can we merge this now?

@benoitf
Copy link
Contributor

benoitf commented Jul 18, 2016

yes we need a PB like https://dev.eclipse.org/ipzilla/show_bug.cgi?id=9980

@benoitf
Copy link
Contributor

benoitf commented Jul 18, 2016

@riuvshin
Copy link
Contributor

I see, so please some one create CQ for that. and let me know when it will be merged.

@ashumilova
Copy link
Contributor

@codenvy-ci
Copy link

@riuvshin riuvshin added this to the 4.5.0 milestone Jul 18, 2016
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
@benoitf
Copy link
Contributor

benoitf commented Jul 19, 2016

1.8.1 is approved with PB CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=10801

@akurinnoy akurinnoy merged commit a414f21 into master Jul 19, 2016
@codenvy-ci
Copy link

Build # 1243 - FAILED

Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1243/ to view the results.

@vparfonov vparfonov deleted the fix_dependency branch July 19, 2016 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants