Per-component override of secret mounts and paths #17167

mshaposhnik · 2020-06-17T05:42:41Z

What does this PR do?

Secret mounting selector changed: instead of optional che.eclipse.org/target-container annotation, a new one is introduced
che.eclipse.org/automount-workspace-secret: true | false, which means automount into all or none workspace containers, but it can be overriden in devfile for each component using automountWorkspaceSecrets: false | true property.
For file-mount secrets, add ability to override mount path in devile component, by specifying
an override volume:

components:
 - type: dockerimage
   alias: maven
   image: maven:3.11
   volumes:
     - name: <secret-name>
       containerPath: /my/new/path

What issues does this PR fix or reference?

#17079

Docs PR

eclipse-che/che-docs#1322 (in progress)

che-bot · 2020-06-17T05:58:32Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17167

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

che-bot · 2020-06-18T16:00:16Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:17167

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

...e/workspace/infrastructure/kubernetes/provision/secret/EnvironmentVariableSecretApplier.java

.../org/eclipse/che/workspace/infrastructure/kubernetes/provision/secret/FileSecretApplier.java

...clipse/che/workspace/infrastructure/kubernetes/provision/secret/KubernetesSecretApplier.java

...rkspace/infrastructure/kubernetes/provision/secret/SecretAsContainerResourceProvisioner.java

che-bot · 2020-06-19T12:05:08Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:17167

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

...rkspace/infrastructure/kubernetes/provision/secret/SecretAsContainerResourceProvisioner.java

che-bot · 2020-06-22T16:52:24Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:17167

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

che-bot · 2020-06-22T17:29:23Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:17167

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

che-bot · 2020-06-24T10:26:22Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:17167

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

.../org/eclipse/che/workspace/infrastructure/kubernetes/provision/secret/FileSecretApplier.java

...clipse/che/workspace/infrastructure/kubernetes/provision/secret/KubernetesSecretApplier.java

che-bot · 2020-06-24T17:15:08Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:17167

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

che-bot · 2020-06-25T19:49:42Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:17167

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

...e/workspace/infrastructure/kubernetes/provision/secret/EnvironmentVariableSecretApplier.java

...rc/main/resources/che-schema/7.15.0/1__add_devfile_component_automount_workspace_secrets.sql

mshaposhnik · 2020-06-26T09:03:24Z

ci-build

che-bot · 2020-06-26T09:17:07Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:17167

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

mshaposhnik · 2020-06-26T11:11:07Z

ci-build

che-bot · 2020-06-26T11:29:20Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:17167

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

mshaposhnik added 6 commits June 11, 2020 14:55

Allow to override secret mount in devfile

5222892

Add path override

d356003

Adde some tests

a2947d7

Fixups in tests & code

65e67b4

split classes to be sipler

53e50db

add some javadocs

146ddb3

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jun 17, 2020

mshaposhnik added 4 commits June 18, 2020 09:21

Code fixups

3c07d47

Merge branch 'master' into secret_override_devfile

9c021f8

Merge with master

a31bd8a

fixup! Merge with master

09bfcf5

mshaposhnik marked this pull request as ready for review June 18, 2020 15:54

mshaposhnik requested review from amisevsk, l0rd, metlos, nickboldt, skabashnyuk and sleshchenko as code owners June 18, 2020 15:54

mshaposhnik requested review from sparkoo and removed request for nickboldt, l0rd, sleshchenko and amisevsk June 18, 2020 15:55

skabashnyuk reviewed Jun 19, 2020

View reviewed changes

Code fixups

a35f69c

skabashnyuk reviewed Jun 19, 2020

View reviewed changes

...rkspace/infrastructure/kubernetes/provision/secret/SecretAsContainerResourceProvisioner.java Show resolved Hide resolved

Review fixes

24d60b4

review fixups

5288dfe

mshaposhnik mentioned this pull request Jun 24, 2020

User should be able to set/retrieve secrets and see them mounted and/or as env variables #14680

Closed

sparkoo reviewed Jun 24, 2020

View reviewed changes

.../org/eclipse/che/workspace/infrastructure/kubernetes/provision/secret/FileSecretApplier.java Outdated Show resolved Hide resolved

sparkoo reviewed Jun 24, 2020

View reviewed changes

.../org/eclipse/che/workspace/infrastructure/kubernetes/provision/secret/FileSecretApplier.java Outdated Show resolved Hide resolved

sparkoo reviewed Jun 24, 2020

View reviewed changes

.../org/eclipse/che/workspace/infrastructure/kubernetes/provision/secret/FileSecretApplier.java Outdated Show resolved Hide resolved

sparkoo reviewed Jun 24, 2020

View reviewed changes

.../org/eclipse/che/workspace/infrastructure/kubernetes/provision/secret/FileSecretApplier.java Show resolved Hide resolved

sparkoo reviewed Jun 24, 2020

View reviewed changes

...clipse/che/workspace/infrastructure/kubernetes/provision/secret/KubernetesSecretApplier.java Outdated Show resolved Hide resolved

mshaposhnik added 2 commits June 24, 2020 19:36

Review fixups

7327514

Review fixups

667d98b

Add some messages on inconsistent secret

d955919

mshaposhnik requested review from sparkoo and skabashnyuk June 25, 2020 19:30

sparkoo approved these changes Jun 25, 2020

View reviewed changes

skabashnyuk approved these changes Jun 26, 2020

View reviewed changes

...e/workspace/infrastructure/kubernetes/provision/secret/EnvironmentVariableSecretApplier.java Show resolved Hide resolved

...rc/main/resources/che-schema/7.15.0/1__add_devfile_component_automount_workspace_secrets.sql Outdated Show resolved Hide resolved

mshaposhnik added 2 commits June 26, 2020 11:57

review fixups

4ed4690

Merge branch 'master' into secret_override_devfile

e2108c9

Fix java 11 usage

99afd7a

mshaposhnik merged commit 3b2dbca into eclipse-che:master Jun 26, 2020

mshaposhnik deleted the secret_override_devfile branch June 26, 2020 16:22

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Per-component override of secret mounts and paths #17167

Per-component override of secret mounts and paths #17167

mshaposhnik commented Jun 17, 2020 •

edited

Loading

che-bot commented Jun 17, 2020

che-bot commented Jun 18, 2020

che-bot commented Jun 19, 2020

che-bot commented Jun 22, 2020

che-bot commented Jun 22, 2020

che-bot commented Jun 24, 2020

che-bot commented Jun 24, 2020

che-bot commented Jun 25, 2020

mshaposhnik commented Jun 26, 2020

che-bot commented Jun 26, 2020

mshaposhnik commented Jun 26, 2020

che-bot commented Jun 26, 2020

Per-component override of secret mounts and paths #17167

Per-component override of secret mounts and paths #17167

Conversation

mshaposhnik commented Jun 17, 2020 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Docs PR

che-bot commented Jun 17, 2020

che-bot commented Jun 18, 2020

che-bot commented Jun 19, 2020

che-bot commented Jun 22, 2020

che-bot commented Jun 22, 2020

che-bot commented Jun 24, 2020

che-bot commented Jun 24, 2020

che-bot commented Jun 25, 2020

mshaposhnik commented Jun 26, 2020

che-bot commented Jun 26, 2020

mshaposhnik commented Jun 26, 2020

che-bot commented Jun 26, 2020

mshaposhnik commented Jun 17, 2020 •

edited

Loading