Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-1231. Show/hide error messages after updating pom.xml #1398

Merged
merged 1 commit into from
Jun 2, 2016

Conversation

RomanNikitenko
Copy link
Member

@RomanNikitenko RomanNikitenko commented May 31, 2016

  1. Display/hide error messages in the pom-file and opened java files after updating pom.xml
  2. Fix showing duplicate error message in the pom.xml when a dependency is not found
  3. Fix showing old error message in the pom.xml (problems with caching )

@vparfonov @evidolob please review

Signed-off-by: Roman Nikitenko rnikitenko@codenvy.com

int end = start + "<project ".length();

List<Problem> problemList = problems.stream().map(mavenProjectProblem -> {
Problem problem = DtoFactory.newDto(Problem.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't use .with*** to chain dto ?

return DtoFactory.newDto(Problem.class).with...with...with

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benoitf done!

@codenvy-ci
Copy link

Build # 773 - FAILED

Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/773/ to view the results.

@codenvy-ci
Copy link

Build # 777 - FAILED

Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/777/ to view the results.

@vparfonov
Copy link
Contributor

ok

@benoitf benoitf added this to the 4.3.0 milestone Jun 1, 2016
Signed-off-by: Roman Nikitenko <rnikitenko@codenvy.com>
@RomanNikitenko RomanNikitenko merged commit ccb66af into master Jun 2, 2016
@RomanNikitenko RomanNikitenko deleted the CHE-1231 branch June 2, 2016 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants