-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update che.sh #1329
Update che.sh #1329
Conversation
Add in catch all error message.
|
||
# CHE-1202: Improve error messages in case of docker ps failure | ||
# Verify that /var/run/docker.sock has owner and group read / write permissions | ||
PERMS=$(stat -c %A /var/run/docker.sock) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Even if docker.sock has owner/group rw permission it doesn't mean that current user is owner or included in needed group.
- docker.sock can have rw permission for others.
sudo chmod 660 /var/run/docker.sock
will help only when user has needed id or gid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We perform the uid check elsewhere in the script. It is checked before getting to this step.
@garagatyi Added formatting. |
Build # 664 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/664/ to view the results. |
LGTM |
Please use squash when you will be ready to merge |
@eivantsov Added check for other group. |
+1 |
Build # 678 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/678/ to view the results. |
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
* Use cwd for terminal creation Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Use cwd only for editor container. Limited by eclipse-che/che#1329 Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Clean up. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
_1 Upvote_ CHE-1202 - Add in checks in case 'docker ps' fails. There are two additional checks. First, verify that group and owner have rw permissions for /var/run/docker.sock. Second, verify that the docker client version and the docker server version match. In situations where docker client is in a Che container and that container is using a host's docker daemon, it is possible for the client and server to not match.
@garagatyi, @eivantsov what do you think?
I don't have a way to generate good tests for this. I did the best that I could in a VM, but all the VMs I create generally don't have either of these issues. Do we have good environments to test for this improvement?