Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redirection loop in case if gwt-ide loaded in the sidecar #13205

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

skabashnyuk
Copy link
Contributor

What does this PR do?

Changes introduced #12864 makes loading gwt ide a bit more complex. Now there is a redirection loop. This pr introduce circuit-breaker.

What issues does this PR fix or reference?

n/a

Release Notes

n/a

Docs PR

n/a

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
Copy link
Contributor Author

ci-test

@skabashnyuk
Copy link
Contributor Author

CC @monaka

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Apr 22, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13205
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@monaka
Copy link
Member

monaka commented Apr 23, 2019

@skabashnyuk Is your Che environment single-host?
I've not tested this patch because my env is multi-host and the similar issue will be fixed by #13142.
But in my opinion, this PR should be merged for running GWT-IDE under single-host env.

@vparfonov How do you think?

@skabashnyuk
Copy link
Contributor Author

@monaka it was tested on single-user che on minishift.

… sidecar

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Apr 23, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13205
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk skabashnyuk merged commit 7f08aa3 into master Apr 23, 2019
@skabashnyuk skabashnyuk deleted the gwtidesidecarloop branch April 23, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants