Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '.d.ts' DTO generator #12250

Merged
merged 3 commits into from
Dec 26, 2018
Merged

Add '.d.ts' DTO generator #12250

merged 3 commits into from
Dec 26, 2018

Conversation

evidolob
Copy link
Contributor

@evidolob evidolob commented Dec 21, 2018

What does this PR do?

Provide new DTO generator for TypeScript which can generate .d.ts file
To enable new generator add:

<dts>true</dts>

in <configuration> section of che-core-typescript-dto-maven-plugin

What issues does this PR fix or reference?

#12132

Also this pull use string union literals for Java Enum types:

export interface MyCustom  {
   status?: 'SHUTDOWN' | 'ALIVE';
}

and adds super interfaces to DTO type declaration:

  // org.eclipse.che.plugin.typescript.dto.MySuperClassDTO
  export interface MySuperClass  {
    name?: string;
  } 
  // org.eclipse.che.plugin.typescript.dto.MyOtherDTO
  export interface MyOther extends MySuperClass {
    name?: string;
  } 

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob added the kind/enhancement A feature request - must adhere to the feature request template. label Dec 21, 2018
@evidolob evidolob self-assigned this Dec 21, 2018
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 21, 2018
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob merged commit 345d1b7 into master Dec 26, 2018
@evidolob evidolob deleted the new-dts-generator branch December 26, 2018 09:15
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 26, 2018
@benoitf benoitf added this to the 6.16.0 milestone Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants