-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keycloak] Fix bugs on the docker image. #11761
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
I've just tested on Helm. I guess there have the similar issue on another runtimes. But I didn't touch them as I'm not familiar with them. |
I believe this patch itself is sane. But I encountered the another issue around authentication with Che. (a) I send the additional PR after closed this as they are separated issues. |
@monaka can you explain how changes you've made related to the topic of this pr? Especially commented lines in kc_realm_user.sh |
@skabashnyuk The current image doesn't contain But actually, it should contain This is a point I commented above. This PR itself is sane. But some additional patches will be required for complete works. |
Let me change the title and the aim for this PR. As I tweeted, I managed to run Che on AKS (managed vanilla Kubernetes). I'm going to add some more patches to here. |
@monaka can you please update the description of this pr with such information:
|
Enable to run Che on vanilla K8s clusters.
Kubernetes.
Azure AKS 1.11.3.
master branch, nightly builds.
After fixing above,
|
Currently, |
@monaka thanks for fixing it. However, I do not understand why you copied jsons? it's ok to use them from where they are |
Indeed it's not good to put same files into different places. But I couldn't resolve how to access JSONs in |
@monaka it is ok to reuse jsons from init. Just changing start script in the entrypoint should be enough, and you did that already |
@eivantsov Who setups the realm for Che? |
@monaka it happens in the entrypoint |
Yes. In addition to patches here, we must add the patch to
|
Can one of the admins verify this PR? |
Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
I close this as it have not been updated. |
What does this PR do?
Fix the container image for Keycloak to use Postgres instead of H2.
What issues does this PR fix or reference?
Release Notes
Docs PR