Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP to 7.2 #11440

Closed
wants to merge 1 commit into from
Closed

Update PHP to 7.2 #11440

wants to merge 1 commit into from

Conversation

filips123
Copy link

It updates PHP from 7.0 to 7.2 in PHP stack description. See eclipse-che/che-dockerfiles#214.

@riuvshin
Copy link
Contributor

riuvshin commented Oct 2, 2018

Can one of the admins verify this patch?

@riuvshin
Copy link
Contributor

riuvshin commented Oct 2, 2018

Can one of the admins verify this patch?

1 similar comment
@riuvshin
Copy link
Contributor

riuvshin commented Oct 2, 2018

Can one of the admins verify this patch?

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 2, 2018
@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

@monaka monaka added the status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. label May 6, 2019
@monaka
Copy link
Member

monaka commented May 6, 2019

@musienko-maxim @filips123 This PR is blocked by eclipse-che/che-dockerfiles#214. And must pass the ECA check.

@monaka
Copy link
Member

monaka commented Jul 17, 2019

@filips123 I think this PR is outdated. Just closing, or re-targeting to Che-6.x ?

@filips123
Copy link
Author

@monaka How should I re-target it to Che 6?

@monaka
Copy link
Member

monaka commented Jul 25, 2019

This PR is obsolete by #13788. I close it.
@filips123 please make new PR to the 6.19.x branch if you want to request merging this.

@monaka monaka closed this Jul 25, 2019
@monaka
Copy link
Member

monaka commented Jul 25, 2019

@filips123 How to re-target is like this.

  1. create new branch from 6.19.x branch on your fork.
  2. cherry-pick your patch in this PR to new branch.
  3. push your branch created on step 1.
  4. create new PR and set the target branch 6.19.x (not the master branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashumilova ashumilova Awaiting requested review from ashumilova

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@filips123 @riuvshin @musienko-maxim @monaka @benoitf