Rework ConvertToProjectWithPomFileTest test for checking conversion folders to maven multimodule project #11427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musienko-maxim
requested review from
dmytro-ndp and
Ohrimenko1988
as code owners
benoitf
added
status/code-review
| */ | ||
| package org.eclipse.che.selenium.miscellaneous; | ||
|
|
||
| import static java.lang.String.*; |
There was a problem hiding this comment.
As far as I know, the common import is a bad practice. Please import relations directly.
| import org.testng.annotations.BeforeClass; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| /** @author Aleksandr Shmaraev */ |
There was a problem hiding this comment.
Is the author name correct?
SkorikSergey
approved these changes
Oct 2, 2018
| convertPredefinedFolderToMavenProjectWithContextMenu( | ||
| format("%s/%s", PROJECT_NAME, WEB_APP_MODULE)); | ||
| testProjectServiceClient.checkProjectType( | ||
| workspaceId, format("%s/%s", PROJECT_NAME, WEB_APP_MODULE), "maven"); |
There was a problem hiding this comment.
What about move all these items to the upper of the test and declare them as constants.
final String convertPath = format("%s/%s", PROJECT_NAME, WEB_APP_MODULE);
| workspaceId, format("%s/%s", PROJECT_NAME, WEB_APP_MODULE), "maven"); | ||
| addParentConfigurationToPredefinedFolder(); | ||
| menu.runCommand( | ||
| TestMenuCommandsConstants.Project.PROJECT, |
| public void shouldNotConvertToMavenProject() { | ||
| projectExplorer.waitAndSelectItem(NONE_MAVEN_PROJECT); | ||
| menu.runCommand( | ||
| TestMenuCommandsConstants.Project.PROJECT, |
Ohrimenko1988
approved these changes
Oct 2, 2018
dmytro-ndp
reviewed
Oct 2, 2018
| @@ -293,6 +293,7 @@ private ProjectConfig getProject(String workspaceId, String projectName) throws | |||
| return requestFactory | |||
| .fromUrl(workspaceAgentApiEndpointUrlProvider.get(workspaceId) + "project/" + projectName) | |||
| .useGetMethod() | |||
| .setAuthorizationHeader(machineServiceClient.getMachineApiToken(workspaceId)) | |||
There was a problem hiding this comment.
Should there be added prefix BEARER_TOKEN_PREFIX + as well?
dmytro-ndp
reviewed
Oct 2, 2018
| @@ -25,6 +25,7 @@ | |||
| public static final String CONSOLE_JAVA_SIMPLE = "console_java_simple.json"; | |||
| public static final String GO = "go.json"; | |||
| public static final String DOT_NET = "dotNet.json"; | |||
| public static final String UNDEFINED_PROJECT = "undefined.json"; | |||
There was a problem hiding this comment.
IMHO next name would better reflect template proposal: PROJECT_OF_UNDEFINED_TYPE
dmytro-ndp
reviewed
Oct 2, 2018
| @Inject private TestProjectServiceClient testProjectServiceClient; | ||
| @Inject private SeleniumWebDriver seleniumWebDriver; | ||
| private String workspaceId; | ||
| @BeforeClass |
There was a problem hiding this comment.
Please, add empty line to improve readability.
dmytro-ndp
reviewed
Oct 2, 2018
| convertToMavenByhWizard("/" + PROJECT_NAME, WEB_APP_MODULE); | ||
| } | ||
|
|
||
| private void convertToMavenByhWizard(String pathToDirectory, String convertedFolder) { |
There was a problem hiding this comment.
typo convertToMavenByhWizard
Also, this method could be useful for other tests, and would be better moved into the Wizard page object.
dmytro-ndp
reviewed
Oct 2, 2018
| private static final String PROJECT_NAME = NameGenerator.generate("project", 4); | ||
| private static final String WEB_APP_MODULE = "my-webapp"; | ||
| private static final String NONE_MAVEN_PROJECT = NameGenerator.generate("noneMavenProject", 4); | ||
| private static final String PARENT_INFORMATION = |
There was a problem hiding this comment.
I would suggest to use more specific name PARENT_ARTIFACT_SECTION.
dmytro-ndp
reviewed
Oct 2, 2018
| wizard.waitCloseProjectConfigForm(); | ||
| } | ||
|
|
||
| private void addParentConfigurationToPredefinedFolder() { |
There was a problem hiding this comment.
I would suggest to use more specific name addParentArticatSectionIntoPomFile
dmytro-ndp
reviewed
Oct 2, 2018
| import org.testng.annotations.Test; | ||
|
|
||
| /** @author Aleksandr Shmaraev, Musienko Maxim */ | ||
| public class CheckConvertingToMavenProjectTest { |
There was a problem hiding this comment.
Test name could be simplified slightly: ConvertToMavenProjectTest
dmytro-ndp
approved these changes
Oct 2, 2018
|
ci-build |
|
ci-build |
benoitf
removed
the
status/code-review
nickboldt
pushed a commit
to nickboldt/che
that referenced
this pull request
Oct 3, 2018
…olders to maven multimodule project (eclipse-che#11427) Rework ConvertToProjectWithPomFileTest test for checking conversion folders to maven multimodule project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
artifactIdwas the same for parent and module and this produces conflict)undefinedproject type for checking autosetting type for projects like thisWhat issues does this PR fix or reference?
#6905