Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[walking skeleton] Introduce ws.next stacks #11088

Merged
merged 1 commit into from
Sep 6, 2018
Merged

[walking skeleton] Introduce ws.next stacks #11088

merged 1 commit into from
Sep 6, 2018

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Sep 6, 2018

What does this PR do?

Introduce two stacks for two examples:

  • Hello World Theia plug-in (+ Theia being added automatically)
  • REST client Theia plug-in (+ Theia being added automatically) + REST server running in its own container

What issues does this PR fix or reference?

#10123

@benoitf
Introduce ws.next stacks
d48de7a 
Change-Id: Iaec703aaa3700cf364506ae6b266736ab62817e8
Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
@benoitf benoitf requested a review from ashumilova as a code owner September 6, 2018 07:30
@benoitf benoitf requested a review from l0rd September 6, 2018 07:39
@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Sep 6, 2018
@benoitf benoitf requested review from skabashnyuk, a user and garagatyi September 6, 2018 09:30
@benoitf benoitf merged commit fa964c3 into master Sep 6, 2018
@benoitf benoitf deleted the ws-next-stack branch September 6, 2018 15:06
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 6, 2018
@benoitf benoitf added this to the 6.11.0 milestone Sep 6, 2018
@SkorikSergey SkorikSergey mentioned this pull request Sep 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0rd l0rd l0rd approved these changes

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@garagatyi garagatyi garagatyi approved these changes

@ashumilova ashumilova Awaiting requested review from ashumilova

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
6.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@benoitf @l0rd @skabashnyuk @garagatyi