Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added subject propagation during WebSocket methods calls #10922

Merged
merged 4 commits into from
Aug 30, 2018

Conversation

sleshchenko
Copy link
Member

What does this PR do?

Adds subject propagation during WebSocket methods calls. It includes:

  • Adds storing of Che Subject into http session in MachineLogin filters
  • Removes excluding for WebSocket endpoint path from MachineLoginFilter binding;
  • Adds settings subject into EnvironmentContext during WebSocket methods calls;

It also does the following small fix:

  • Moves exclude of OIDCKeycloak.js to mapping instead of Filter class;

What issues does this PR fix or reference?

It is needed for #10861.

Release Notes

N/A

Docs PR

N/A

@sleshchenko sleshchenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Aug 27, 2018
@sleshchenko sleshchenko self-assigned this Aug 27, 2018
@sleshchenko sleshchenko requested a review from riuvshin as a code owner August 27, 2018 11:03
@sleshchenko
Copy link
Member Author

ci-test

@riuvshin
Copy link
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10922
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@l0rd l0rd mentioned this pull request Aug 29, 2018
57 tasks
@sleshchenko
Copy link
Member Author

ci-test

@riuvshin
Copy link
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10922
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@sleshchenko sleshchenko merged commit 2fa298a into eclipse-che:master Aug 30, 2018
@sleshchenko sleshchenko deleted the subjectPropagation branch August 30, 2018 07:18
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 30, 2018
@benoitf benoitf added this to the 6.11.0 milestone Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants