Added attributes field to workspace config object #10721
Conversation
sleshchenko
requested review from
skabashnyuk,
mshaposhnik,
garagatyi and
akurinnoy
sleshchenko
requested review from
ashumilova,
benoitf and
vparfonov
as code owners
|
ci-test |
benoitf
added
status/code-review
| @@ -111,6 +117,14 @@ public String getDefaultEnv() { | |||
| return environments; | |||
| } | |||
|
|
|||
| @Override | |||
| public Map<String, String> getAttributes() { | |||
| if (attributes == null) { | |||
There was a problem hiding this comment.
Attrs are initialized in constructor, so they probably shouldn't be null
There was a problem hiding this comment.
It's not actually true.
Attributes are initialized in constructor only if the corresponding constructor parameter is not null. Also, there is a setter method that may receive null and set it into the attributes field.
There was a problem hiding this comment.
@mshaposhnik You're right =) It though it is WorkspaceConfigImpl from workspace-api module.
BTW Comment about constructor parameter is actual for ide workspace config impl too.
|
|
||
| --Workspace config attributes --------------------------------------------------------- | ||
| CREATE TABLE che_workspace_cfg_attributes ( | ||
| workspace_id VARCHAR(255), |
There was a problem hiding this comment.
we need index for this field workspace_id
| @@ -0,0 +1,20 @@ | |||
| -- | |||
| -- Copyright (c) 2012-2018 Red Hat, Inc. | |||
| -- All rights reserved. This program and the accompanying materials | |||
| @@ -57,4 +57,9 @@ | |||
| * least 1 default environment and may contain N environments. | |||
| */ | |||
| Map<String, ? extends Environment> getEnvironments(); | |||
|
|
|||
| /** | |||
| * Returns workspace config attributes. Workspace attributes must not contain null keys or values. | |||
There was a problem hiding this comment.
Pls rephrase 2nd sentence to be clear that it is talking about config attributes
sleshchenko
changed the title
|
ci-test build report: |
|
ci-test |
sleshchenko
force-pushed
the
wsConfigAttributes
branch
from
704f877 to
7e1ad81
Compare
|
ci-test build report: |
benoitf
removed
the
status/code-review
Removed duplicated declaration of che-core-api-core dependency Added attributes field to workspace config object Fetch Che plugins from WorkspaceConfig's attributes instead of Workspace's ones Remove duplicated declarations in pom file of postgresql-tck module
What does this PR do?
Adds attributes field to workspace config object.
Fetches Che plugins from WorkspaceConfig's attributes instead of Workspace's ones. It allows using Che plugins in stacks and factories.
What issues does this PR fix or reference?
#10368
Release Notes
Docs PR