Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LSP client proxy support dynamicRegistration for client capabilities #9797

Closed
dkuleshov opened this issue May 24, 2018 · 6 comments
Closed
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@dkuleshov
Copy link

Actual implementation does not support dynamic client capabilities registration. In order to make the workflow more flexible we should support it. Seems like depending on the implementation some servers can provide capabilities dynamically (e.g. Golang server).

See WorkspaceClientCapabilities and TextDocumentClientCapabilities in LSP Specification.

@gorkem
Copy link
Contributor

gorkem commented May 24, 2018

@dkuleshov Is this a blocker for Golang server? jdt.ls also supports dynamic capabilities however if a client does not support it the server should be able to fall-back to fixed capability reporting. If this is not the case for Golang we should report it.

@ghost ghost added kind/task Internal things, technical debt, and to-do tasks to be performed. team/ide labels May 29, 2018
@dkuleshov
Copy link
Author

dkuleshov commented May 29, 2018

@gorkem According to what I see golang LS ignores dynamicRegistration set to false and tries to register a new capability. The bug is reported here #9796, we will report the golang LS bug if it is confirmed during the work on our bug.

I'm not yet sure if that's a blocker for #9781 but if it is than it will be mentioned here as well.

@vparfonov vparfonov added status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach kind/enhancement A feature request - must adhere to the feature request template. and removed kind/task Internal things, technical debt, and to-do tasks to be performed. labels May 30, 2018
@vparfonov
Copy link
Contributor

Will take to the nearest sprint for analyzing this ability for our client

@gorkem
Copy link
Contributor

gorkem commented May 30, 2018

@vparfonov Do we really need this supported on the GWT IDE? LS implementations are supposed to work without it.

@vparfonov
Copy link
Contributor

I think it's just nice to have, not critical. Firstly we need to upgrade lsp4j (#9864), and fix several technical impediments. Which mainly comes from our feature for supporting multi language server for on opened file.

@vparfonov vparfonov removed status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach team/ide labels Sep 15, 2018
@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2019
@che-bot che-bot closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants