Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opened in the Editor files tabs are not restored after workspace restarting #14717

Closed
5 of 24 tasks
SkorikSergey opened this issue Sep 30, 2019 · 6 comments
Closed
5 of 24 tasks

Opened in the Editor files tabs are not restored after workspace restarting #14717

SkorikSergey opened this issue Sep 30, 2019 · 6 comments
Assignees
@vzhukovs
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@SkorikSergey
Copy link
Contributor

Describe the bug

After workspace restarting files tabs opened in the Editor are not restored.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Create and start a workspace from any devfile with a project.
  2. Click on Projects tab.
  3. Open in the Editor any file.
  4. On the Dashboard open Workspaces page and stop/start the workspace in Workspaces list page.
  5. Open the workspace and check files tabs in the Editor.

Expected behavior

Opened previously files tabs are opened in the Editor.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Screencasts

screencast-che-eclipse-che 10 33 177 124 nip io-2019 09 30-17_24_13 (1)

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • ocp.sh
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context
@SkorikSergey SkorikSergey added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 30, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 30, 2019
@tolusha
Copy link
Contributor

tolusha commented Oct 1, 2019

The question is where Theia stores opened editors and if it is kept when workspace is stopped.

[1] https://spectrum.chat/theia?tab=posts

@l0rd l0rd added team/ide2 severity/P2 Has a minor but important impact to the usage or development of the system. kind/enhancement A feature request - must adhere to the feature request template. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. kind/bug Outline of a bug - must adhere to the bug report template. labels Oct 2, 2019
@l0rd
Copy link
Contributor

l0rd commented Oct 2, 2019

It doesn't look like a bug (has that ever worked on Che with theia?) but an enhancement with severity/p2.

SkorikSergey added a commit that referenced this issue Oct 3, 2019
@SkorikSergey
add info about #14717 issue to ProjectStateAfterWorkspaceRestartTest
21e6ca1
@dmytro-ndp dmytro-ndp mentioned this issue Nov 27, 2019
Closed
19 tasks
@vzhukovs vzhukovs self-assigned this Feb 4, 2020
@vzhukovs
Copy link
Contributor

vzhukovs commented Feb 4, 2020

@tolusha theia stores the application state in browser local storage, but in che-theia there is our own implementation of storage service that stores application state on file system. I suppose, that this configuration files don't serialize and don't store somewhere. And we need to provide mechanism to provision them into theia container.

@vzhukovs vzhukovs mentioned this issue Feb 5, 2020
Closed
@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2020
@davidwindell
Copy link
Contributor

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2020
@l0rd l0rd added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 21, 2020
@SkorikSergey
Copy link
Contributor Author

This feature works well on Eclipse Che 7.44.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vzhukovs vzhukovs

Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@l0rd @tolusha @davidwindell @vzhukovs @SkorikSergey @che-bot