Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDE should respect commands from Runtime #12053

Closed
sleshchenko opened this issue Nov 27, 2018 · 0 comments
Closed

IDE should respect commands from Runtime #12053

sleshchenko opened this issue Nov 27, 2018 · 0 comments
Assignees
@vparfonov
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@sleshchenko
Copy link
Member

Description

Che Plugins in Che 7 may provide commands which are not specified in WorkspaceConfig because of that Workspace#Runtime now returns a list of actual commands #9546
One more reason why commands from Runtime should be used - a command may be configured to be executed in plugin's container while machineName is expected by Exec sidecar, so Che Server will resolve machineName attribute during Plugin Brokering according to specified plugin attribute value.

So, it is needed to adapt IDEs to respect commands from Runtime instead of using commands from WorkspaceConfig.
@sleshchenko sleshchenko mentioned this issue Nov 27, 2018
Closed
@slemeur slemeur mentioned this issue Nov 27, 2018
Closed
42 tasks
@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. team/ide labels Dec 1, 2018
@vparfonov vparfonov mentioned this issue Dec 3, 2018
Closed
15 tasks
@vparfonov vparfonov self-assigned this Dec 3, 2018
@slemeur slemeur mentioned this issue Dec 20, 2018
Closed
69 tasks
@vparfonov vparfonov mentioned this issue Dec 21, 2018
Closed
11 tasks
@vparfonov vparfonov mentioned this issue Jan 3, 2019
Merged
vparfonov added a commit to eclipse/che-theia-task-plugin that referenced this issue Jan 3, 2019
@vparfonov
Merge pull request #17 from eclipse/eclipse-che/che#12053
cd750d4 
Respect commands from Runtime
@vparfonov vparfonov mentioned this issue Jan 10, 2019
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vparfonov vparfonov

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skabashnyuk @vparfonov @sleshchenko